rename VersionStalenessFilter to trigger

Author: pthirun

internal/venice-common/src/main/java/com/linkedin/venice/ConfigKeys.java

@@ -415,14 +415,23 @@ private ConfigKeys() {
   public static final String REPUSH_ORCHESTRATOR_CLASS_NAME = "controller.repush.orchestrator.class.name";
 
   /**
-   * Class names of the implementation of interface {@link com.linkedin.venice.controller.logcompaction.RepushCandidateFilter} in {@link com.linkedin.venice.controller.logcompaction.CompactionManager}
-   * These are prerequisite filters evaluated with AND logic (all must pass).
+   * Class names of the implementation of interface
+   * {@link com.linkedin.venice.controller.logcompaction.RepushCandidateFilter} used by
+   * {@link com.linkedin.venice.controller.logcompaction.CompactionManager}.
+   *
+   * <p>Filters are chained with AND logic: <b>all</b> filters must pass for a store to remain a candidate.
+   * They enforce exclusion criteria such as cluster config, store eligibility, and migration status.</p>
    */
   public static final String REPUSH_CANDIDATE_FILTER_CLASS_NAMES = "controller.repush.candidate.filter.class.names";
 
   /**
-   * Class names of the implementation of interface {@link com.linkedin.venice.controller.logcompaction.RepushCandidateTrigger} in {@link com.linkedin.venice.controller.logcompaction.CompactionManager}
-   * These are trigger conditions evaluated with OR logic (any must pass).
+   * Class names of the implementation of interface
+   * {@link com.linkedin.venice.controller.logcompaction.RepushCandidateTrigger} used by
+   * {@link com.linkedin.venice.controller.logcompaction.CompactionManager}.
+   *
+   * <p>Triggers are chained with OR logic: at least <b>one</b> trigger must pass for a store to be scheduled.
+   * They represent conditions that independently justify compaction (e.g., version staleness,
+   * high duplicate key ratio). A store is scheduled when all filters pass AND any trigger passes.</p>
    */
   public static final String REPUSH_CANDIDATE_TRIGGER_CLASS_NAMES = "controller.repush.candidate.trigger.class.names";
 

services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java

@@ -74,7 +74,7 @@
 import com.linkedin.venice.controller.logcompaction.RepushCandidateFilter;
 import com.linkedin.venice.controller.logcompaction.RepushCandidateTrigger;
 import com.linkedin.venice.controller.logcompaction.StoreRepushCandidateFilter;
-import com.linkedin.venice.controller.logcompaction.VersionStalenessFilter;
+import com.linkedin.venice.controller.logcompaction.VersionStalenessTrigger;
 import com.linkedin.venice.controller.multitaskscheduler.MultiTaskSchedulerService;
 import com.linkedin.venice.controller.multitaskscheduler.StoreMigrationManager;
 import com.linkedin.venice.controller.repush.RepushJobRequest;
@@ -928,7 +928,7 @@ private Set<RepushCandidateTrigger> getRepushCandidateTriggersFromControllerConf
     Set<RepushCandidateTrigger> candidateTriggers = new HashSet<>();
 
     // Default trigger: version staleness
-    candidateTriggers.add(new VersionStalenessFilter(multiClusterConfigs));
+    candidateTriggers.add(new VersionStalenessTrigger(multiClusterConfigs));
 
     // Additional triggers from config
     for (String candidateTriggerClassName: multiClusterConfigs.getRepushCandidateTriggerClassNames()) {

…ogcompaction/VersionStalenessFilter.java …gcompaction/VersionStalenessTrigger.javaservices/venice-controller/src/main/java/com/linkedin/venice/controller/logcompaction/VersionStalenessFilter.java renamed to services/venice-controller/src/main/java/com/linkedin/venice/controller/logcompaction/VersionStalenessTrigger.java services/venice-controller/src/main/java/com/linkedin/venice/controller/logcompaction/VersionStalenessFilter.java renamed to services/venice-controller/src/main/java/com/linkedin/venice/controller/logcompaction/VersionStalenessTrigger.java

@@ -16,12 +16,12 @@
  * As a {@link RepushCandidateTrigger}, this participates in OR logic with other triggers — if any
  * trigger passes, the store is scheduled for compaction (provided all prerequisite filters also pass).
  */
-public class VersionStalenessFilter implements RepushCandidateTrigger {
-  private static final Logger LOGGER = LogManager.getLogger(VersionStalenessFilter.class);
+public class VersionStalenessTrigger implements RepushCandidateTrigger {
+  private static final Logger LOGGER = LogManager.getLogger(VersionStalenessTrigger.class);
 
   private final Map<String, Long> versionStalenessThresholdsByCluster = new HashMap<>();
 
-  public VersionStalenessFilter(VeniceControllerMultiClusterConfig multiClusterConfig) {
+  public VersionStalenessTrigger(VeniceControllerMultiClusterConfig multiClusterConfig) {
     for (String clusterName: multiClusterConfig.getClusters()) {
       VeniceControllerClusterConfig config = multiClusterConfig.getControllerConfig(clusterName);
       this.versionStalenessThresholdsByCluster.put(clusterName, config.getLogCompactionVersionStalenessThresholdMS());

services/venice-controller/src/test/java/com/linkedin/venice/controller/logcompaction/CompactionManagerTest.java

@@ -76,7 +76,7 @@ public void setUp() {
     Set<RepushCandidateFilter> candidateFilters =
         Collections.singleton(new StoreRepushCandidateFilter(multiClusterConfig));
     Set<RepushCandidateTrigger> candidateTriggers =
-        Collections.singleton(new VersionStalenessFilter(multiClusterConfig));
+        Collections.singleton(new VersionStalenessTrigger(multiClusterConfig));
 
     testCompactionManager =
         new CompactionManager(mockRepushOrchestrator, candidateFilters, candidateTriggers, statsMap);