Skip to content

Commit 917360b

Browse files
committed
Reapply "[test] Update epoch rewind test to allow EOP replay policy"
This reverts commit 7acb8c8.
1 parent 7acb8c8 commit 917360b

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

clients/venice-push-job/src/test/java/com/linkedin/venice/hadoop/TestKafkaFormatTopicAutoDiscover.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,15 @@ public void testUserProvidedEpochRewind() {
8787
}
8888
}
8989

90+
/**
91+
* With epoch passthrough (rewindEpochTimeInSecondsOverride), the absolute epoch timestamp flows
92+
* directly through the pipeline, so the SOP/EOP replay policy no longer matters. EOP stores
93+
* should be allowed to use epoch-based rewind without throwing. Previously this test asserted
94+
* that EOP + epoch override would throw — that restriction has been removed.
95+
* See design: DESIGN_rewind_epoch_passthrough.md, Section 3.4.5.
96+
*/
9097
@Test
91-
public void testUserProvidedEpochRewindWithInvalidRemotePolicy() {
98+
public void testUserProvidedEpochRewindWithEOPPolicy() {
9299
final int singleColoCurrentVersion = 1;
93100
ControllerClient controllerClient = mock(ControllerClient.class);
94101
Map<String, Integer> coloToVersionMap = Collections.emptyMap();
@@ -105,7 +112,8 @@ public void testUserProvidedEpochRewindWithInvalidRemotePolicy() {
105112
venicePushJob.setControllerClient(controllerClient);
106113
venicePushJob.initKIFRepushDetails();
107114
venicePushJob.setControllerClient(controllerClient);
108-
Assert.assertThrows(venicePushJob::validateRemoteHybridSettings);
115+
// Should NOT throw — epoch rewind works with any replay policy (SOP or EOP)
116+
venicePushJob.validateRemoteHybridSettings();
109117
}
110118
}
111119

0 commit comments

Comments
 (0)