Address PR review: use debug logging and reduce test duplication

- Change LOGGER.info to LOGGER.debug in
StoreRequestHandler.getClusterHealthStores()
- Consolidate test methods using @dataProvider to reduce duplication in
StoreRequestHandlerTest

Author: pthirun

services/venice-controller/src/main/java/com/linkedin/venice/controller/server/StoreRequestHandler.java

@@ -270,9 +270,9 @@ public MultiStoreStatusResponse getClusterHealthStores(String clusterName) {
       throw new IllegalArgumentException("Cluster name is required");
     }
 
-    LOGGER.info("Getting health status for all stores in cluster: {}", clusterName);
+    LOGGER.debug("Getting health status for all stores in cluster: {}", clusterName);
     Map<String, String> storeStatusMap = admin.getAllStoreStatuses(clusterName);
-    LOGGER.info("Found {} stores with health status in cluster: {}", storeStatusMap.size(), clusterName);
+    LOGGER.debug("Found {} stores with health status in cluster: {}", storeStatusMap.size(), clusterName);
 
     MultiStoreStatusResponse response = new MultiStoreStatusResponse();
     response.setCluster(clusterName);

services/venice-controller/src/test/java/com/linkedin/venice/controller/server/StoreRequestHandlerTest.java

@@ -36,6 +36,7 @@
 import java.util.Map;
 import java.util.Optional;
 import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
 
@@ -364,43 +365,34 @@ public void testListStoresWithDataReplicationPolicyFilterNullPolicy() {
     assertEquals(response.getStoreNamesCount(), 0);
   }
 
-  @Test
-  public void testGetClusterHealthStoresSuccess() {
-    Map<String, String> storeStatusMap = new HashMap<>();
-    storeStatusMap.put("store1", "ONLINE");
-    storeStatusMap.put("store2", "DEGRADED");
-    storeStatusMap.put("store3", "UNAVAILABLE");
-    when(admin.getAllStoreStatuses("testCluster")).thenReturn(storeStatusMap);
-
-    MultiStoreStatusResponse response = storeRequestHandler.getClusterHealthStores("testCluster");
-
-    verify(admin, times(1)).getAllStoreStatuses("testCluster");
-    assertEquals(response.getCluster(), "testCluster");
-    assertEquals(response.getStoreStatusMap().size(), 3);
-    assertEquals(response.getStoreStatusMap().get("store1"), "ONLINE");
-    assertEquals(response.getStoreStatusMap().get("store2"), "DEGRADED");
-    assertEquals(response.getStoreStatusMap().get("store3"), "UNAVAILABLE");
+  @DataProvider(name = "storeStatusMaps")
+  public Object[][] storeStatusMaps() {
+    Map<String, String> populatedMap = new HashMap<>();
+    populatedMap.put("store1", "ONLINE");
+    populatedMap.put("store2", "DEGRADED");
+    populatedMap.put("store3", "UNAVAILABLE");
+    return new Object[][] { { populatedMap }, { Collections.emptyMap() } };
   }
 
-  @Test
-  public void testGetClusterHealthStoresEmptyMap() {
-    when(admin.getAllStoreStatuses("testCluster")).thenReturn(Collections.emptyMap());
+  @Test(dataProvider = "storeStatusMaps")
+  public void testGetClusterHealthStores(Map<String, String> expectedStatusMap) {
+    when(admin.getAllStoreStatuses("testCluster")).thenReturn(expectedStatusMap);
 
     MultiStoreStatusResponse response = storeRequestHandler.getClusterHealthStores("testCluster");
 
     verify(admin, times(1)).getAllStoreStatuses("testCluster");
     assertEquals(response.getCluster(), "testCluster");
-    assertEquals(response.getStoreStatusMap().size(), 0);
+    assertEquals(response.getStoreStatusMap(), expectedStatusMap);
   }
 
-  @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Cluster name is required")
-  public void testGetClusterHealthStoresMissingClusterName() {
-    storeRequestHandler.getClusterHealthStores(null);
+  @DataProvider(name = "blankClusterNames")
+  public Object[][] blankClusterNames() {
+    return new Object[][] { { null }, { "" } };
   }
 
-  @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Cluster name is required")
-  public void testGetClusterHealthStoresEmptyClusterName() {
-    storeRequestHandler.getClusterHealthStores("");
+  @Test(dataProvider = "blankClusterNames", expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Cluster name is required")
+  public void testGetClusterHealthStoresWithBlankClusterName(String clusterName) {
+    storeRequestHandler.getClusterHealthStores(clusterName);
   }
 
   @Test