Skip to content

Commit f98ba5f

Browse files
pthirunclaude
andcommitted
Address PR review comments
- Remove FQCN usage for RepushInfoResponse (use short class name) - Add proper import for RepushInfoResponse - Add null check for repushInfo before setting it on response Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 4b8b2ea commit f98ba5f

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

services/venice-controller/src/main/java/com/linkedin/venice/controller/server/StoreRequestHandler.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.linkedin.venice.controller.ControllerRequestHandlerDependencies;
55
import com.linkedin.venice.controller.StoreDeletedValidation;
66
import com.linkedin.venice.controllerapi.RepushInfo;
7+
import com.linkedin.venice.controllerapi.RepushInfoResponse;
78
import com.linkedin.venice.exceptions.VeniceException;
89
import com.linkedin.venice.exceptions.VeniceNoStoreException;
910
import com.linkedin.venice.meta.Store;
@@ -268,10 +269,7 @@ public ListStoresGrpcResponse listStores(ListStoresGrpcRequest request) {
268269
* @param fabric optional fabric for multi-region setups
269270
* @return RepushInfoResponse containing repush information including version and Kafka details
270271
*/
271-
public com.linkedin.venice.controllerapi.RepushInfoResponse getRepushInfo(
272-
String clusterName,
273-
String storeName,
274-
Optional<String> fabric) {
272+
public RepushInfoResponse getRepushInfo(String clusterName, String storeName, Optional<String> fabric) {
275273
LOGGER.info(
276274
"Getting repush info for store: {} in cluster: {} with fabric: {}",
277275
storeName,
@@ -280,11 +278,12 @@ public com.linkedin.venice.controllerapi.RepushInfoResponse getRepushInfo(
280278

281279
RepushInfo repushInfo = admin.getRepushInfo(clusterName, storeName, fabric);
282280

283-
com.linkedin.venice.controllerapi.RepushInfoResponse response =
284-
new com.linkedin.venice.controllerapi.RepushInfoResponse();
281+
RepushInfoResponse response = new RepushInfoResponse();
285282
response.setCluster(clusterName);
286283
response.setName(storeName);
287-
response.setRepushInfo(repushInfo);
284+
if (repushInfo != null) {
285+
response.setRepushInfo(repushInfo);
286+
}
288287
return response;
289288
}
290289

0 commit comments

Comments
 (0)