fix: remove obsolete RoleCondition.name property

Author: beeman

libs/api/core/data-access/src/lib/api-core.service.ts

@@ -8,7 +8,24 @@ import { slugifyId, slugifyUsername } from './helpers/slugify-id'
 export class ApiCoreService {
   private readonly logger = new Logger(ApiCoreService.name)
   readonly data: ApiCorePrismaClient = prismaClient
-  constructor(readonly config: ApiCoreConfigService) {}
+  constructor(readonly config: ApiCoreConfigService) {
+    // Get all the condition that have a name to reset them to null
+    this.data.roleCondition
+      .findMany({
+        where: { name: { not: null } },
+        select: { id: true },
+      })
+      .then((conditions) => {
+        console.log('Found conditions with name', conditions)
+        conditions.forEach((condition) => {
+          console.log(`Resetting name for condition ${condition.id}`)
+          this.data.roleCondition.update({
+            where: { id: condition.id },
+            data: { name: null },
+          })
+        })
+      })
+  }
 
   async createCommunity({ input, userId }: { input: Prisma.CommunityCreateInput; userId?: string }) {
     const id = slugifyId(input.name).toLowerCase()

libs/api/role/data-access/src/lib/api-admin-role.service.ts

@@ -34,7 +34,7 @@ export class ApiAdminRoleService {
     return this.core.data.role.findUnique({
       where: { id: roleId },
       include: {
-        conditions: { include: { token: true }, orderBy: { name: 'asc' } },
+        conditions: { include: { token: true }, orderBy: { createdAt: 'asc' } },
         community: true,
         permissions: { include: { botRole: true } },
       },

libs/api/role/data-access/src/lib/api-role-resolver.service.ts

@@ -360,7 +360,6 @@ export class ApiRoleResolverService {
           config: true,
           filters: true,
           id: true,
-          name: true,
           type: true,
           role: true,
           token: {
@@ -374,7 +373,6 @@ export class ApiRoleResolverService {
           amount: condition.amount ?? undefined,
           config: condition.config ?? undefined,
           filters: condition.filters ?? undefined,
-          name: condition.name ?? condition.type,
           token: condition.token ?? undefined,
         })),
       )

libs/api/role/data-access/src/lib/api-user-role.service.ts

@@ -27,7 +27,6 @@ export class ApiUserRoleService {
       data: {
         config: input.config ?? undefined,
         filters: input.filters ?? undefined,
-        name: input.type.toString(),
         role: { connect: { id: input.roleId } },
         token: { connect: { id: input.tokenId } },
         type: input.type,
@@ -103,7 +102,7 @@ export class ApiUserRoleService {
     return this.core.data.role.findUnique({
       where: { id: roleId },
       include: {
-        conditions: { include: { token: true }, orderBy: { name: 'asc' } },
+        conditions: { include: { token: true }, orderBy: { createdAt: 'asc' } },
         community: true,
         permissions: { include: { botRole: true } },
       },

prisma/schema.prisma

@@ -244,7 +244,7 @@ model RoleCondition {
   amount    String           @default("0")
   config    Json?
   filters   Json?
-  name      String
+  name      String?
   token     NetworkToken     @relation(fields: [tokenId], references: [id])
   tokenId   String
   role      Role             @relation(fields: [roleId], references: [id], onDelete: Cascade)