Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a paragraph body to each map on the clean feed #744

Closed
wants to merge 2 commits into from
Closed

Adds a paragraph body to each map on the clean feed #744

wants to merge 2 commits into from

Conversation

claytron5000
Copy link

Fixes #248 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

This is a pretty rough fix. I was unable to get the site running locally, so I couldn't really replicate the functionality. I suspect this will require more work, though I'm trying to follow the link provided in the issue description.

@welcome
Copy link

welcome bot commented Jun 24, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Jun 24, 2019

Code Climate has analyzed commit 1ec6b27 and detected 0 issues on this pull request.

View more on Code Climate.

@claytron5000 claytron5000 mentioned this pull request Jul 1, 2019
Open
5 tasks
jywarren
jywarren requested changes Jul 2, 2019
View reviewed changes
app/views/feeds/clean.builder Outdated
@@ -8,6 +8,7 @@ xml.rss "version" => "2.0", "xmlns:dc" => "http://purl.org/dc/elements/1.1/" do
xml.description "Recently posted maps at MapKnitter.org, a Public Lab open source research initiative"

@maps.each do |map|
map.body = "<p><img src='" map.warpables.first.image.url(:medium) "' alt='" map.name"'/></p>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! However, I think the change needs to happen further down on line 20, modifying xml.description map.description.to_s + " " + map.warpables.first.image.url(:medium) + spamlink

Would you mind making this change? Thanks so much!

@kaustubh-nair
Copy link
Member

hi @claytron5000 any updates on this?
Feel free to ask for help if required

@claytron5000
Copy link
Author

How does this look?

@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f968ffc). Click here to learn what that means.
The diff coverage is 42.62%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage        ?   38.35%           
=======================================
  Files           ?       40           
  Lines           ?     1705           
  Branches        ?        0           
=======================================
  Hits            ?      654           
  Misses          ?     1051           
  Partials        ?        0
Impacted Files Coverage Δ
app/controllers/export_controller.rb 0% <0%> (ø)
app/controllers/maps_controller.rb 0% <0%> (ø)
app/models/warpable.rb 71.87% <100%> (ø)
app/models/user.rb 97.14% <100%> (ø)
app/controllers/front_ui_controller.rb 45.45% <45%> (ø)
app/helpers/front_ui_helper.rb 71.42% <71.42%> (ø)
app/models/map.rb 86.45% <85.71%> (ø)

@kaustubh-nair
Copy link
Member

Oh sorry I didn't look at this sooner @claytron5000
I think you missed an 'end' somewhere
Travis logs is reporting syntax error https://travis-ci.org/publiclab/mapknitter/jobs/565132494
I think it should be easy to fix
Thanks!

@cesswairimu
Copy link
Collaborator

This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RSS feed to properly include images
4 participants
@claytron5000 @kaustubh-nair @cesswairimu @jywarren