Added Dangerfile to root directory of mapknitter #306

satyajeetmaharana · 2019-01-26T20:31:41Z

Fixes #303

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

tests pass -- rake test
code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

welcome · 2019-01-26T20:31:44Z

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Dangerfile

grvsachdeva

Hi @satyajeetmaharana, could you please make these little changes. They are required because we are using Dangerfile in mapknitter. Thanks!

Dangerfile

Co-Authored-By: satyajeetmaharana <[email protected]>

grvsachdeva · 2019-01-26T20:47:08Z

Please check appropriate boxes in the checklist - #306 (comment) . Thanks!

grvsachdeva · 2019-01-26T21:17:36Z

There's one more suggestion left. And, just a suggestion: Using Fixes #[issue-number] in the PR comment closes the tagged issue when PR gets merged so it's nice practice. Thanks!

satyajeetmaharana · 2019-01-26T21:46:54Z

Hi @gauravano , Thank for the suggestion. I will keep it as a standard practice in my future PRs. For this issue, I have updated the PR comment. Hope it looks good now.
Thank you again for your help.

grvsachdeva · 2019-01-27T08:29:01Z

Edited - #306 (comment)

grvsachdeva

There's still a suggestion pending!

Co-Authored-By: satyajeetmaharana <[email protected]>

grvsachdeva

Looks good to me! Thanks @satyajeetmaharana for working on this.

grvsachdeva · 2019-01-28T22:53:00Z

Hey @jywarren, @satyajeetmaharana has added Dangerfile to the repo, could you please complete the installation of dangerbot. Thanks!

jywarren · 2019-01-29T14:49:49Z

Awesome. I think the remaining step is adjusting the .travis.yml file and configuring in Travis:

https://danger.systems/guides/getting_started.html#setting-up-danger-to-run-on-your-ci

jywarren · 2019-01-29T14:51:17Z

See for example: https://github.com/publiclab/plots2/blob/master/.travis.yml -- i'll try this.

jywarren · 2019-01-29T14:52:24Z

OK, just noting that plots2 project has a pretty customized setup. I'll try to get it running in the default mode as in the Danger docs, but if that doesn't work we can copy these lines:

https://github.com/publiclab/plots2/blob/9a2596886e2da54e797905d124d68fac7cddcf58/.travis.yml#L27-L34

jywarren · 2019-01-29T15:03:45Z

I see command not found: danger -- so trying the plots2 way!

jywarren · 2019-01-29T15:23:57Z

.travis.yml


 script:
-  - docker-compose run web bash -c "rake test"
+  - docker-compose run web bash -c "CI=TRUE GENERATE_REPORT=true rake test"


Hmm, oddly plots2 uses exec instead of run here. But that didn't work. So trying run as it was originally here.

ERROR: No container found for web_1 was the error...

jywarren · 2019-01-29T15:24:38Z

Also adding the correct token to Travis for Danger posting!

jywarren · 2019-01-29T15:28:01Z

Sorry just going to start it again to have it see the token!

plotsbot · 2019-01-29T15:34:24Z

	1 Error
🚫	There was an error with Danger bot’s Junit parsing: undefined method `value’ for nil:NilClass

	2 Messages
📖	@satyajeetmaharana Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	#<NoMethodError: undefined method `value’ for nil:NilClass>

Generated by 🚫 Danger

jywarren · 2019-01-29T15:36:43Z

Hooray! Looks like it's running, but just not properly parsing the errors produced in JUnit format.

jywarren · 2019-01-29T15:38:16Z

K interesting, it's saying:


Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
installing your bundle as root will break this application for all non-root
users on this machine.
Fetching gem metadata from https://rubygems.org/..Retrying dependency api due to error (2/3): Bundler::HTTPError Net::HTTPBadGateway: 
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html>
  <head>
    <title>502 Bad Gateway</title>
  </head>

jywarren · 2019-01-29T15:40:40Z

I dunno, i don't see anything obvious so i'm going to restart it again to see if it was some kind of connectivity issue or an upstream server not responding properly?

jywarren · 2019-01-31T03:29:23Z

Aha!

tail -n +2 -q ./test/reports/TEST*.xml >> output.xml
tail: cannot open ‘./test/reports/TEST*.xml’ for reading: No such file or directory
The command "tail -n +2 -q ./test/reports/TEST*.xml >> output.xml" exited with 1.

Ok, looking...

jywarren · 2019-01-31T03:40:29Z

Looked carefully through plots2 and found we needed additions to test/test_helper.rb!

jywarren · 2019-02-01T03:32:23Z

Trying exec again...

alaxalves · 2019-03-01T14:23:29Z

@jywarren Everytime you use 'run' either with docker or docker-compose it creates a new container, so anything you have done previously won't have desired behavior since you've done it in another container. I suggest changing everywhere that has 'run' to 'exec'.

alaxalves · 2019-03-01T14:25:51Z

Gemfile

@@ -42,6 +42,9 @@ group :test do
 end

 group :development do


This should be in a group :test doesn't it? 🤔

jywarren · 2019-03-01T15:59:49Z

hi @alaxalves - thank you! Would you like to try opening a PR based on this? You know a lot about Docker and we'd LOVE your help!

jywarren · 2019-03-01T16:00:18Z

Or merging this with your PR at #363 ?

alaxalves · 2019-03-01T17:37:19Z

Hey @jywarren I feel like it would be less painful if we get #363 before this. When its done I could open a PR regarding this. What do you think? 😄

plotsbot · 2019-03-01T17:37:58Z

sounds good, thank you!

…

On Fri, Mar 1, 2019 at 12:37 PM Álax de Carvalho Alves < ***@***.***> wrote: Hey @jywarren <https://github.com/jywarren> I feel like it would be less painful if we get #363 <#363> before this. When its done I could open a PR regarding this. What do you think? 😄 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#306 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ah3Vc2BRoO1OkaiOmOo6k5bpx66ftGeuks5vSWVQgaJpZM4aUXlX> .

jywarren · 2019-03-01T17:40:37Z

Hahaha, i got the notification from the plotsbot account and responded there, sorry, it thought i was plotsbot! 😂

alaxalves · 2019-03-01T17:54:15Z

@jywarren 😆 😆 😆 😆 Okay then!!

grvsachdeva · 2019-07-28T08:18:31Z

Hi @alaxalves, as #363 is done. Can we push it to completion? Thank you!

Changes required in setup

codeclimate · 2019-08-11T09:15:36Z

Code Climate has analyzed commit ca178b5 and detected 0 issues on this pull request.

View more on Code Climate.

kaustubh-nair · 2019-08-19T06:27:42Z

Reopened in #926

Iss # 303 - Added Dangerfile

b30e816

grvsachdeva reviewed Jan 26, 2019

View reviewed changes

Dangerfile Outdated Show resolved Hide resolved

satyajeetmaharana mentioned this pull request Jan 26, 2019

Add dangerfile to the project #303

Open

5 tasks

grvsachdeva requested changes Jan 26, 2019

View reviewed changes

Dangerfile Outdated Show resolved Hide resolved

Update Dangerfile - Changed source_path from "plots2" to "mapknitter"

b1633b7

Co-Authored-By: satyajeetmaharana <[email protected]>

satyajeetmaharana changed the title ~~Issue # 303 - Added Dangerfile to root directory of mapknitter~~ Fixes #[303] - Added Dangerfile to root directory of mapknitter Jan 26, 2019

grvsachdeva changed the title ~~Fixes #[303] - Added Dangerfile to root directory of mapknitter~~ Added Dangerfile to root directory of mapknitter Jan 27, 2019

grvsachdeva requested changes Jan 27, 2019

View reviewed changes

Update Dangerfile

029be05

Co-Authored-By: satyajeetmaharana <[email protected]>

grvsachdeva previously approved these changes Jan 28, 2019

View reviewed changes

grvsachdeva added the ready label Jan 28, 2019

grvsachdeva requested a review from jywarren January 28, 2019 22:52

Update .travis.yml

78fb85e

jywarren added 2 commits January 29, 2019 12:05

Update .travis.yml

d5322ce

Update .travis.yml

fcfff90

jywarren reviewed Jan 29, 2019

View reviewed changes

Update test_helper.rb

3c9702f

Update Gemfile

5052f90

jywarren mentioned this pull request Feb 1, 2019

Planning issue: expand test coverage with more thorough testing #304

Closed

Update .travis.yml

ca178b5

alaxalves reviewed Mar 1, 2019

View reviewed changes

Gemfile

@@ -42,6 +42,9 @@ group :test do

end

group :development do

Copy link

Member

alaxalves Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a group :test doesn't it? 🤔

grvsachdeva added in-progress and removed ready labels Jul 28, 2019

kaustubh-nair closed this Aug 11, 2019

kaustubh-nair reopened this Aug 11, 2019

kaustubh-nair closed this Aug 19, 2019

Added Dangerfile to root directory of mapknitter #306

Added Dangerfile to root directory of mapknitter #306

Conversation

satyajeetmaharana commented Jan 26, 2019 • edited by grvsachdeva Loading

welcome bot commented Jan 26, 2019

grvsachdeva left a comment

Choose a reason for hiding this comment

grvsachdeva commented Jan 26, 2019

grvsachdeva commented Jan 26, 2019

satyajeetmaharana commented Jan 26, 2019

grvsachdeva commented Jan 27, 2019

grvsachdeva left a comment

Choose a reason for hiding this comment

grvsachdeva left a comment

Choose a reason for hiding this comment

grvsachdeva commented Jan 28, 2019

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

jywarren Jan 29, 2019

Choose a reason for hiding this comment

jywarren Jan 29, 2019

Choose a reason for hiding this comment

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

plotsbot commented Jan 29, 2019 • edited Loading

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

jywarren commented Jan 29, 2019

jywarren commented Jan 31, 2019

jywarren commented Jan 31, 2019

jywarren commented Feb 1, 2019

alaxalves commented Mar 1, 2019

alaxalves Mar 1, 2019

Choose a reason for hiding this comment

jywarren commented Mar 1, 2019

jywarren commented Mar 1, 2019

alaxalves commented Mar 1, 2019

plotsbot commented Mar 1, 2019 via email

jywarren commented Mar 1, 2019 • edited Loading

alaxalves commented Mar 1, 2019

grvsachdeva commented Jul 28, 2019

codeclimate bot commented Aug 11, 2019

kaustubh-nair commented Aug 19, 2019

satyajeetmaharana commented Jan 26, 2019 •

edited by grvsachdeva

Loading

plotsbot commented Jan 29, 2019 •

edited

Loading

jywarren commented Mar 1, 2019 •

edited

Loading