Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed .width()-100 to .width()-160 #1009

Closed
wants to merge 1 commit into from
Closed

Changed .width()-100 to .width()-160 #1009

wants to merge 1 commit into from

Conversation

catehernandez
Copy link

Fixes #898 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x ] PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Sep 11, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Sep 11, 2019

Code Climate has analyzed commit f37106d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #1009 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1009   +/-   ##
=====================================
  Coverage   73.7%   73.7%           
=====================================
  Files         40      40           
  Lines       1388    1388           
=====================================
  Hits        1023    1023           
  Misses       365     365

CodeSarthak
CodeSarthak approved these changes Dec 9, 2019
View reviewed changes
Copy link

@CodeSarthak CodeSarthak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @zenon21 :)

Go check out https://github.com/publiclab for more issues which you can work on. Happy contributing.

keshav234156
keshav234156 reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@keshav234156 keshav234156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenon21 Please attach the screenshot of the changes. Please try to have a descriptive title of the PR and the corresponding commits

@cesswairimu
Copy link
Collaborator

re-invoking travis

@cesswairimu
Copy link
Collaborator

seems the branch was deleted and can reopen. @zenon21 feel free to push it up. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshav234156 keshav234156 keshav234156 left review comments

@CodeSarthak CodeSarthak CodeSarthak approved these changes

@prashant-pushkar prashant-pushkar prashant-pushkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map-bars not displayed in a single line
6 participants
@catehernandez @cesswairimu @CodeSarthak @keshav234156 @prashant-pushkar @zenon21