Fix crash when editing profile for non-existent user#11875
Open
mowems wants to merge 3 commits intopubliclab:mainfrom
Open
Fix crash when editing profile for non-existent user#11875mowems wants to merge 3 commits intopubliclab:mainfrom
mowems wants to merge 3 commits intopubliclab:mainfrom
Conversation
Author
|
It looks like the CI failures might be coming from deprecated GitHub Actions (for example The changes here are focused on handling non-existent users in the profile edit flow, and everything is working as expected locally. Happy to take a look at the workflow files and open a separate PR to help fix the CI if that would be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent crash when editing non-existent user profile
Problem
Accessing
/profile/:id/editwith a non-existent username caused a server error due to@userbeing nil.Solution
Added a guard clause in
UsersController#editto handle cases where the user is not found.Result
The application now redirects safely with an error message instead of crashing.
Testing
/profile/fakeuser/edit