Skip to content

Add icon to copy URL of the wiki page and deleting the URL column #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add icon to copy URL of the wiki page and deleting the URL column #5519

wants to merge 1 commit into from

Conversation

gautamig54
Copy link
Contributor

@gautamig54 gautamig54 commented Apr 18, 2019 •
edited
Loading

Fixes #5467 (<=== Add issue number here)

Screen Shot 2019-04-18 at 7 09 51 PM

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

2 Messages
📖 @gautamig54 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@gautamig54
Copy link
Contributor Author

@publiclab/reviewers Kindly review this PR! Thanks!

@gautamig54
Copy link
Contributor Author

@gauravano What do you think about this?

@grvsachdeva
Copy link
Member

It looks cleaner now. I think, using a link instead of copy would be better. Hmm, having a dedicated column would be better or showing the icon only on hovering over the row? Or, no change required? @jywarren thoughts. Thanks!

@gautamig54
Copy link
Contributor Author

Thanks for the review @gauravano.
I can even design the copy icon in the first column if it looks abrupt.

@grvsachdeva
Copy link
Member

I am sure you can @gautamig54. But, let's wait for @jywarren or @publiclab/community-reps as this is design issue and requires their input. Also, I don't want to waste your efforts and time. Thanks!

@asquare14
Copy link
Member

@gautamig54 Please resolve conflicts. @jywarren What are your thoughts ?

@grvsachdeva grvsachdeva requested a review from jywarren June 25, 2019 19:07
@jywarren
Copy link
Member

Just looking back to the purpose of this path originally, i see:

#3776
#3744

I can't remember why we wanted this!

What if we put the extra information under a ... menu? Then the whole table would be simpler, and we could still add extra details in there, like # of revisions, # of authors, things like that?

@asquare14
Copy link
Member

@jywarren Sounds better :D

asquare14
asquare14 reviewed Jul 2, 2019
View reviewed changes
Copy link
Member

@asquare14 asquare14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase from master. Any updates on this @gautamig54 ?

@asquare14
Copy link
Member

Any updates ?

@gautamig54
Copy link
Contributor Author

hi @asquare14! Actually the design for the wiki page is not yet finalised. So we are not working on this rn. Thanks!

@asquare14
Copy link
Member

Should we maybe close this PR as we won't be working on it anymore ?

@gautamig54
Copy link
Contributor Author

Sure @asquare14! I'll close this PR for now.

@gautamig54 gautamig54 closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asquare14 asquare14 asquare14 left review comments

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove URL column from the wiki table
5 participants
@gautamig54 @plotsbot @grvsachdeva @asquare14 @jywarren