Filter subscriptions to the existing tags or notes

[gautamig54]

Currently, I am able to subscribe the tags that don't even exist by typing them to the enter tags input section.

I wrote "abcdjdiw" and it is added to the subscription list. Clearly this is junk subscription.
I think we should filter out such tags and display an alert message saying that the tag/note does not exists and thus cannot be subscribed to.

[gautamig54]

@publiclab/plots2-reviewers What do you think about this?

[IshaGupta18]

So you are able to just add the tag or subscribe to it? If you are able to subscribe to it, then this is an actual problem. We can work on this together if you like.

…

On Sat, Apr 20, 2019, 5:09 PM Gautami Gupta ***@***.***> wrote: @publiclab/plots2-reviewers <https://github.com/orgs/publiclab/teams/plots2-reviewers> What do you think about this? — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#5555 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ5TUX47URWGJ77UTFTPRL6GBANCNFSM4HHJQC5Q> .

[gautamig54]

@IshaGupta18 I think we are able to subscribe to it.

[IshaGupta18]

Yes we are! Okay we can brainstorm on it together, on how to go about it. What do you think?

…

On Sat, Apr 20, 2019, 5:13 PM Gautami Gupta ***@***.***> wrote: @IshaGupta18 <https://github.com/IshaGupta18> I think we are able to subscribe to it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5555 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ7RVIKNMZ3E5K2AWTDPRL6XLANCNFSM4HHJQC5Q> .

[grvsachdeva]

Okay, one case is where irrespective of the presence of tag, user wants to get subscribed (Just a random thought). @jywarren this case should be considered? If no, then, we are good to go here. Thanks!

[jywarren]

Hmm, how does it currently happen -- does it create the tag and subscribe to it? Since anyone can make tags, what happens if you subscribe to 'unique-tag' and then tag a post with the same tag?

…

On Fri, Apr 26, 2019 at 11:16 AM Gaurav Sachdeva ***@***.***> wrote: Okay, one case is where irrespective of the presence of tag, user wants to get subscribed (Just a random thought). @jywarren <https://github.com/jywarren> this case should be considered? If no, then, we are good to go here. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5555 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J5SJFKVSPI434EQ53DPSMMBRANCNFSM4HHJQC5Q> .

[grvsachdeva]

does it create the tag and subscribe to it?

Yes!

Since anyone can make tags, what happens if you subscribe to 'unique-tag' and then tag a post with the same tag?

It works fine as we check for the existence of tag while adding.

Also, while experimenting with tags, I found that when I try to subscribe to same tag again it shows "you are now following tagname" but in subscription_controller we handle such cases so we need to fix that too.

Thanks!

[gautamig54]

Yes @gauravano. Regarding the already subscribed tag, I've created another issue #5556.
If a user is already subscribed, it will show already subscribed instead of the present message.

[grvsachdeva]

Yes, it's a bug, I have edited your issue a bit just now. Thanks for pointing!