Skip to content

Removal of read more button and corrected the pagination #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removal of read more button and corrected the pagination #5818

wants to merge 1 commit into from

Conversation

AnshitaVishwa
Copy link
Contributor

@AnshitaVishwa AnshitaVishwa commented Jun 1, 2019

Fixes #5618 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@AnshitaVishwa
Copy link
Contributor Author

@jywarren and @gauravano Please review this PR. Thanks!!

@grvsachdeva
Copy link
Member

Hi @AnshitaVishwa, I tried your PR by pushing onto unstable.publiclab.org. The button is removed as issue demands but the pagination bar is not working. Would you like to look into that? Thanks!

@AnshitaVishwa
Copy link
Contributor Author

@gauravano would you please help me out in correcting the pagination fault?
Thank you.

@CleverFool77
Copy link
Member

Hi @AnshitaVishwa Can I know that what problem you are coming across for pagination ?

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significance of "Read more" button on home page
4 participants