Upgraded Editform as per Bootstrap4 #5800
Conversation
|
Hi @dinaelhanan, can you send a screenshot of the changes you have done. That will be a lot helpful. Thank you!! |
|
Hi @dinaelhanan Are you still working on this ? |
|
@CleverFool77 Hi, I'm having issues with my local dev environment - could you please try to run this branch on your end? I'd really appreciate it if you could try too @Souravirus , thank you! |
|
Oh no problem. I'll check this. |
There was a problem hiding this comment.
Hi @dinaelhanan
This is the screenshot of your PR.
Do you think it would be better if we can have fields taking column-6 and then spanning over column-12 in medium and greater screens as we were doing earlier in bootstrap 3 ? The screenshot that we are have right now would be good for smaller screen which will get stack with the help of col-md-6 .What do you say ?
|
hey @CleverFool77 , I'm not sure I get what you mean, can you point out the lines of code you're referring to? Thank you so much for your help :) |
There was a problem hiding this comment.
Hi @dinaelhanan
Can you do something like this ? I wrote the abstract of what I wanted to say in #5741 (comment). Just follow it. And it would be done.
<div class="row">
<div class="col-md-12"> // A statement
<div class="col-md-6"> // child class 1 of A //statement B
<div class="col-md-12"> // child class 1 of B
<!-- username -->
</div>
<div class="col-md-12"> // child class 2 of B
<!-- email -->
</div>
</div>
<div class"col-md-6"> //child class 2 of A // sibling with B
<!-- put image here -->
</div>
</div>
<div class="col-md-12"> // statement C // sibling with A
<div class="col-md-6"> // child class 1 of C
<!-- current password -->
</div>
<div class="col-md-6"> // child class 2 of C
<!-- email again -->
</div>
</div>
<div class="col-md-12"> // statement D // sibling with A and C
<div class="col-md-6"> // child class 1 of D
<!-- new password -->
</div>
<div class="col-md-6"> // child class 2 of D
<!-- confirm new password -->
</div>
</div>
<div class="col-md-12"> // statement E // sibling with A , C and D
<!-- bio -->
</div>
<!-- save button -->
</div>Thanks !!
|
If this is not understandable then I guess @jywarren @gautamig54 might help you in understanding better. |
|
Hi @dinaelhanan. @CleverFool77 explained the solution pretty well. Reach out to us if you need more guidance. Great work! |
|
@CleverFool77 Hi, I'm sorry I've left this unattended for some time, I started my internship and it was intense in the beginning, just starting to get back into the contributing habit! I've made the requested changes. Thank you for explaining this and let me know if there's any more issues. |
No problem, Now having a ss would do. |
|
@dinaelhanan Are you still working on this ? Just having an update with screenshot would do ? |
|
@dinaelhanan Any updates ? OR I might close this issue ? |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Fixes #5741
rake test@publiclab/reviewersfor help, in a comment below