Skip to content

fixed style of link button on command bar #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixed style of link button on command bar #7657

wants to merge 1 commit into from

Conversation

diogobest
Copy link

@diogobest diogobest commented Mar 15, 2020 •
edited
Loading

Fixes #7594 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 15, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Mar 15, 2020 •
edited
Loading

Codecov Report

Merging #7657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7657   +/-   ##
======================================
  Coverage    81.9%   81.9%           
======================================
  Files          97      97           
  Lines        5615    5615           
======================================
  Hits         4599    4599           
  Misses       1016    1016

@diogobest
Copy link
Author

Plots2 uses the woofmark for the textarea. The 'create link button' is not getting the classes "btn" and "btn-default" for the style. I created a script in jquery that after pressing the 'create link button' we add the two classes.
I didn't find why the button is not getting the classes yet.

@diogobest diogobest changed the title fixed style of anchor button fixed style of link button on command bar Mar 15, 2020
pydevsg
pydevsg reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@pydevsg pydevsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diogobest please share a screenshot of the work you have done, thanks.

@nicoleiocana
Copy link
Contributor

nicoleiocana commented Apr 8, 2020 •
edited
Loading

@pydevsg This is incorrect. The classes are to be updated in the dist/PublicLab.Editor.js file. Specifically, on lines 19788 & 19789 respectively. The update that upholds the DRY principal is to update the code to this:

    cancel: e('button', 'wk-prompt-cancel btn btn-default', 'Cancel'),
    ok: e('button', 'wk-prompt-ok btn btn-default', 'Ok'),

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pydevsg pydevsg pydevsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different styles in similar buttons in commands bar
4 participants
@diogobest @nicoleiocana @SidharthBansal @pydevsg