externalise jquery using jquery-rails-cdn and jquery-rails fallback #8161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8161 +/- ##
==========================================
- Coverage 82.10% 79.88% -2.23%
==========================================
Files 100 100
Lines 5751 5866 +115
==========================================
- Hits 4722 4686 -36
- Misses 1029 1180 +151
|
|
@jywarren @cesswairimu can you kindly review? Thanks ✌️ Should I first push on unstable? 😅 |
Tlazypanda
force-pushed
the
externalize_jquery
branch
from
82e0b82 to
192c68a
Compare
|
|
|
|
|
|
40 tasks
|
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7920
Externalise jquery using jquery-rails-cdn and jquery-rails fallback to improve performance in terms of -
Automatically fallback to jquery-rails' bundled jQuery when:
On top of that, if you're using asset pipeline, you may have noticed that the major chunks of the code in combined application.js is jQuery. Implications of externalizing jQuery from application.js are:
rake test@publiclab/reviewersfor help, in a comment belowThanks!