Fixed the hard coded sorting for profiles search #10693

johnmarkstrickland · 2022-02-05T11:58:24Z

The profile search was hard coded to perform only one type of sorting, so I removed that hard code in the controller and added in getting the users choice from the parameters.

Fixes #9334

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[✅] PR is descriptively titled 📑 and links the original issue above 🔗
[ ✅] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
[✅ ] code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

welcome · 2022-02-05T11:58:26Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-02-05T11:58:27Z

codecov · 2022-02-05T12:07:55Z

Codecov Report

Merging #10693 (ca27d6d) into main (4d31f1d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #10693      +/-   ##
==========================================
+ Coverage   82.43%   82.45%   +0.01%     
==========================================
  Files          98       98              
  Lines        5990     5996       +6     
==========================================
+ Hits         4938     4944       +6     
  Misses       1052     1052

Impacted Files	Coverage Δ
app/controllers/search_controller.rb	`97.67% <100.00%> (ø)`
app/services/search_service.rb	`95.19% <100.00%> (+0.29%)`	⬆️

github-actions · 2022-02-05T12:08:09Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5189402947/artifacts/157954797

github-actions · 2022-02-05T12:33:23Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5189519584/artifacts/157962294

codeclimate · 2022-02-05T16:59:49Z

app/services/search_service.rb

-        user_scope.joins(:revisions)
-        .where("node_revisions.status = 1")
-        .order("node_revisions.timestamp #{search_criteria.order_direction}")
+      user_scope.joins(:revisions)


Use 2 (not 0) spaces for indentation.

github-actions · 2022-02-05T17:10:06Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5190655217/artifacts/158045944

github-actions · 2022-02-06T11:34:38Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5194557821/artifacts/158330321

TildaDares · 2022-02-07T09:12:47Z

Hi @jstrickl-tunes, do you think you could add functional tests for this feature? Take a look at some test examples you can use as a guide

plots2/test/functional/api/search_api_test.rb

Lines 11 to 30 in dc60919

    
           test 'search profiles by username without order_by and default sort_direction' do 
        
             get '/api/srch/profiles?query=steff&field=username' 
        
             assert last_response.ok? 
        
             # Expected search pattern 
        
             pattern = { 
        
               srchParams: { 
        
                 query: 'steff', 
        
                 seq: nil, 
        
               }.ignore_extra_keys! 
        
             }.ignore_extra_keys! 
        
             matcher = JsonExpressions::Matcher.new(pattern) 
        
             json = JSON.parse(last_response.body) 
        
             assert_equal "/profile/steff3",   json['items'][0]['doc_url'] 
        
             assert_equal "/profile/steff2",   json['items'][1]['doc_url'] 
        
             assert_equal "/profile/steff1",   json['items'][2]['doc_url'] 
        
             assert matcher =~ json 
        
           end

Great job!!

github-actions · 2022-03-04T15:02:03Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5537179448/artifacts/178094266

github-actions · 2022-03-05T20:51:14Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5547966918/artifacts/178779847

github-actions · 2022-03-05T22:06:46Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5548259001/artifacts/178798728

github-actions · 2022-03-05T22:43:31Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5548398012/artifacts/178807528

github-actions · 2022-03-06T10:52:06Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5551085237/artifacts/178997371

codeclimate · 2022-03-06T11:07:09Z

Code Climate has analyzed commit ca27d6d and detected 0 issues on this pull request.

View more on Code Climate.

github-actions · 2022-03-06T11:17:10Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5551179721/artifacts/179003940

stale · 2023-03-11T13:24:29Z

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

Fixed the hard coded sorting for profiles search

f72bc19

Removed unusable (currently) conditional statement

e560c77

added back and fixed the search service

96deda6

codeclimate bot reviewed Feb 5, 2022

View reviewed changes

fixed indentation

e7697b8

Merge branch 'publiclab:main' into fix_search_sorting

c934d75

written new tests to cover the three new cases

a1a3925

changed the users.yml inactiveuser

edb3087

Fixed tests

032f6ac

Tried fixing tests again

5a02b79

jstrickl-tunes added 3 commits March 6, 2022 10:54

testing out other users

424bc24

updated my tests

d1fb43d

Had to remove second assertion

ca27d6d

stale bot added the stale label Mar 11, 2023

stale bot closed this Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the hard coded sorting for profiles search #10693

Fixed the hard coded sorting for profiles search #10693

johnmarkstrickland commented Feb 5, 2022 •

edited

Loading

welcome bot commented Feb 5, 2022

gitpod-io bot commented Feb 5, 2022

codecov bot commented Feb 5, 2022 •

edited

Loading

github-actions bot commented Feb 5, 2022

github-actions bot commented Feb 5, 2022

codeclimate bot Feb 5, 2022

github-actions bot commented Feb 5, 2022

github-actions bot commented Feb 6, 2022

TildaDares commented Feb 7, 2022

github-actions bot commented Mar 4, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 6, 2022

codeclimate bot commented Mar 6, 2022

github-actions bot commented Mar 6, 2022

stale bot commented Mar 11, 2023

Fixed the hard coded sorting for profiles search #10693

Fixed the hard coded sorting for profiles search #10693

Conversation

johnmarkstrickland commented Feb 5, 2022 • edited Loading

welcome bot commented Feb 5, 2022

gitpod-io bot commented Feb 5, 2022

codecov bot commented Feb 5, 2022 • edited Loading

Codecov Report

github-actions bot commented Feb 5, 2022

github-actions bot commented Feb 5, 2022

codeclimate bot Feb 5, 2022

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2022

github-actions bot commented Feb 6, 2022

TildaDares commented Feb 7, 2022

github-actions bot commented Mar 4, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 5, 2022

github-actions bot commented Mar 6, 2022

codeclimate bot commented Mar 6, 2022

github-actions bot commented Mar 6, 2022

stale bot commented Mar 11, 2023

johnmarkstrickland commented Feb 5, 2022 •

edited

Loading

codecov bot commented Feb 5, 2022 •

edited

Loading