Import French translations from Transifex (template issue for copying)

[jywarren]

@ebarry notes that a French translation team has been working on translations for a year (!! wow awesome!) and we'd like to import these. (cc lead French translator @XavCC)

I wanted to note steps here so we do this with good coordination:

• check what's ready to be imported (do they need reviews?)
• check what would be imported (i'm not sure we can do /only/ french translations so this might involve importing all new strings, which is OK too, just good to be clear about
• run the import, generating a new pull request with all the new translations
• add the language code (i.e. fr) to this line: https://github.com/publiclab/plots2/blob/main/config/application.rb#L58
• merge it!
• Check by going to https://publiclab.org/change_locale/fr
• add new languages to the footer dropdown (via the Features system, so for example https://publiclab.org/change_locale/hi-IN for Hindi.)

We can run through part of this checklist each time we do it.

[XavCC]

I could spend a few hours this weekend reviewing translated strings.

[jywarren]

Hi, @XavCC !! Awesome to hear from you and thank you for all the excellent work!

Just an update from our dashboard, French is 100% translated, but about 15% reviewed, but marked "ready to use":

So, we can download either ALL the french translations OR just those that are reviewed:

I wanted to see if we could get input from the reviewers team on whether to import all or just reviewed? Either seems pretty easy!

Also i see @XavCC, OscarTrente and jibe_b are reviewers but only @XavCC seems to have a github account under that name. Happy to hear from other reviewers if that's helpful!

[jywarren]

Note /all/ translations are available in #9482 now, so if we don't want to review first, we can just merge this and do reviews in a later import! Thanks!

[jywarren]

Interesting that we can do this in an automated way from the settings/integration dialog:

This can be part of a new documentation of how to run imports, on https://publiclab.org/wiki/translation

[govindgoel]

@jywarren This is really awesome and now we can do it in an automated way too.

[jywarren]

OK, we'll go ahead and merge the French set for now and we can make modifications later if folks want to review more! Thank you!!!

[jywarren]

Noting a missing step - i found we need to add the language code fr to this line:

plots2/config/application.rb

Line 58 in 8c729b2

I18n.available_locales = [:en, :de, "zh-CN", :ar, :es, "hi-IN", :it, :ko, "pt-BR", :ru]

[jywarren]

That worked! It should publish this coming weekend to the live site:

[jywarren]

Reopening as we got an error in integration tests prob from the config change...

Reverting in #9504

https://github.com/publiclab/plots2/pull/9504/checks?check_run_id=2337234225#step:7:144

Minitest::UnexpectedError:         ActionView::Template::Error: missing interpolation argument :search in "Aucun résultat trouvé en cherchant \"%{search}\"" ({:tag=>"some-tag"} given)
            app/helpers/application_helper.rb:158:in `translation'
            app/views/tag/widget.html.erb:14:in `_app_views_tag_widget_html_erb__3684193017882036563_47228995284600'
            app/controllers/tag_controller.rb:250:in `widget'
            test/integration/I18n_test.rb:425:in `block (2 levels) in <class:I18nTest>'
            test/integration/I18n_test.rb:421:in `each'
            test/integration/I18n_test.rb:421:in `block in <class:I18nTest>'

== FAIL I18nTest#test_should_choose_i18n_for_user/_form_+_user/new (224.46s)
        <Nom d'utilisateur·ice> expected but was
        <Nom d'utilisat⋅eur·ice>..
        Expected 0 to be >= 1.
        test/integration/I18n_test.rb:198:in `block (2 levels) in <class:I18nTest>'
        test/integration/I18n_test.rb:194:in `each'
        test/integration/I18n_test.rb:194:in `block in <class:I18nTest>'