Skip to content

Tweak order of bundle installations #9897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Tweak order of bundle installations #9897

wants to merge 2 commits into from

Conversation

cesswairimu
Copy link
Collaborator

Fixes #9871 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 10, 2021

@cesswairimu cesswairimu mentioned this pull request Jul 10, 2021
Open
@codecov
Copy link

codecov bot commented Jul 10, 2021 •
edited
Loading

Codecov Report

Merging #9897 (ec315f6) into main (f41f8e7) will increase coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9897      +/-   ##
==========================================
+ Coverage   82.13%   82.26%   +0.12%     
==========================================
  Files          98       98              
  Lines        5968     5966       -2     
==========================================
+ Hits         4902     4908       +6     
+ Misses       1066     1058       -8
Impacted Files Coverage Δ
app/helpers/application_helper.rb 85.41% <50.00%> (ø)
app/services/search_service.rb 95.00% <100.00%> (-0.10%) ⬇️
app/api/srch/search.rb 71.33% <0.00%> (+4.45%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren
Copy link
Member

This looks good - @cesswairimu did it help on the startup sequence?

@cesswairimu
Copy link
Collaborator Author

hi@jywarren no, it didn't...trying a couple of more tweaks today

@cesswairimu cesswairimu force-pushed the gitpod-fixes-attempt branch from d210ede to ec315f6 Compare August 1, 2021 09:43
@codeclimate
Copy link

codeclimate bot commented Aug 1, 2021

Code Climate has analyzed commit ec315f6 and detected 0 issues on this pull request.

View more on Code Climate.

@cesswairimu
Copy link
Collaborator Author

I have restarted it a couple of times and its launching fine each time, I will try to see if I can get a couple of people to try out the same on their end.

@cesswairimu cesswairimu mentioned this pull request Aug 1, 2021
Closed
@cesswairimu cesswairimu changed the title [wip]Tweak order of bundle installations Tweak order of bundle installations Aug 1, 2021
@jywarren jywarren closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitpod not working correctly due to bundler version mismatch
2 participants
@cesswairimu @jywarren