Remove limit value clamping
#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't cap `limit` and let the server perform value validation. refactor(subscribe): replace legacy `t` with `tt` and `tr` Replace legacy timetoken query parameter with subscribe v2 parameters. fix(heartbeat): fix `state` query parameter Send proper object for `state` with the `heartbeat` request.
parfeon
added
status: done
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
chore(CODEOWNERS): add new SDK maintainer Add `@mohitpubnub` as Ruby SDK maintainer.
mohitpubnub
approved these changes
Nov 4, 2025
| else | ||
| [Pubnub::Constants::MAXIMUM_HERE_NOW_COUNT, @limit].min | ||
| end | ||
| @limit = Pubnub::Constants::MAXIMUM_HERE_NOW_COUNT if @limit.nil? |
There was a problem hiding this comment.
So are we going to allow value more than MAXIMUM_HERE_NOW_COUNT?
There was a problem hiding this comment.
n/m
limit higher than 1000 and negative offset are handled on server side.
I read this now
jguz-pubnub
approved these changes
Nov 4, 2025
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(heartbeat): fix
statequery parameterSend proper object for
statewith theheartbeatrequest.refactor(here-now): remove
limitvalue clampingDon't cap
limitand let the server perform value validation.refactor(subscribe): replace legacy
twithttandtrReplace legacy timetoken query parameter with subscribe v2 parameters.