Require form and pub pub_type agreement in pub memberships

Author: kalilsn

core/playwright/externalFormInvite.spec.ts

@@ -303,6 +303,35 @@ test.describe("Inviting a new user to fill out a form", () => {
 		await expect(newPage.getByText("This page could not be found.")).toHaveCount(1);
 	});
 
+	test("Invite fails if pub and form pub_types don't match", async () => {
+		const pubDetailsPage = new PubDetailsPage(
+			page,
+			community.community.slug,
+			community.pubs[2].id
+		);
+		await pubDetailsPage.goTo();
+
+		await pubDetailsPage.runAction(
+			ACTION_NAME_EMAIL,
+			async (runActionDialog) => {
+				await runActionDialog
+					.getByLabel("Email body")
+					.fill(
+						`Please fill out :link[this form]{form=${community.pubTypes.Evaluation.defaultForm.slug}}`
+					);
+			},
+			false
+		);
+		await page.getByText("Failed to Send Email", { exact: true }).waitFor();
+		await expect(
+			page
+				.getByLabel("Notifications (F8)")
+				.getByText(
+					"Invitation failed. The specified form is for Evaluation pubs but this pub's type is Submission"
+				)
+		).toBeVisible();
+	});
+
 	// happy path
 	test("Invites without creating a new user", async () => {
 		await test.step("admin sends invite to non-existing user", async () => {

core/playwright/fixtures/pub-details-page.ts

@@ -15,7 +15,8 @@ export class PubDetailsPage {
 
 	async runAction(
 		actionName: string,
-		configureCallback?: (runActionDialog: Locator) => Promise<void>
+		configureCallback?: (runActionDialog: Locator) => Promise<void>,
+		waitForSuccess = true
 	) {
 		await this.page.getByTestId("run-action-primary").click();
 		await this.page.getByRole("button", { name: actionName }).click();
@@ -26,11 +27,13 @@ export class PubDetailsPage {
 		await configureCallback?.(runActionDialog);
 
 		await runActionDialog.getByRole("button", { name: "Run", exact: true }).click();
-		await this.page
-			.getByRole("status")
-			.filter({ hasText: "Action ran successfully!" })
-			.waitFor();
-		await runActionDialog.getByRole("button", { name: "Close", exact: true }).click();
-		await runActionDialog.waitFor({ state: "hidden" });
+		if (waitForSuccess) {
+			await this.page
+				.getByRole("status")
+				.filter({ hasText: "Action ran successfully!" })
+				.waitFor();
+			await runActionDialog.getByRole("button", { name: "Close", exact: true }).click();
+			await runActionDialog.waitFor({ state: "hidden" });
+		}
 	}
 }

core/prisma/migrations/20250507032809_add_pub_memberships_trigger/migration.sql

@@ -0,0 +1,62 @@
+-- For all new pub memberships that specify a form, make sure that the form's pub type is the same
+-- as the pub's pub type
+CREATE OR REPLACE FUNCTION check_pub_membership_pubtype_agreement () RETURNS TRIGGER AS $$
+    DECLARE
+        pub_pub_type RECORD;
+        form_pub_type RECORD;
+    BEGIN
+        IF (NEW."formId" IS NULL) THEN
+            RETURN NEW;
+        END IF;
+
+        SELECT pt.id, pt.name INTO pub_pub_type
+        FROM pubs JOIN pub_types pt ON pt.id = pubs."pubTypeId"
+        WHERE pubs.id = NEW."pubId";
+
+        SELECT pt.id, pt.name INTO form_pub_type
+        FROM forms JOIN pub_types pt ON pt.id = forms."pubTypeId"
+        WHERE forms.id = NEW."formId";
+
+        IF (pub_pub_type.id != form_pub_type.id) THEN
+            RAISE EXCEPTION 'Pub membership creation failed. The specified form is for % pubs but this pub''s type is %', form_pub_type.name, pub_pub_type.name;
+        END IF;
+        RETURN NEW;
+    END;
+$$ LANGUAGE plpgsql;
+
+CREATE TRIGGER check_pub_membership_pubtype_agreement
+AFTER INSERT ON "pub_memberships" FOR EACH ROW
+EXECUTE FUNCTION check_pub_membership_pubtype_agreement ();
+
+-- For all new invites that create a pub membership with a form, make sure that the form's pub type
+-- is the same as the pub's pub type The above trigger would also fire in this situation, but not
+-- until the user claims the invite. This error message is intended for an admin, so we use an
+-- additional trigger to raise it when the invite is created
+CREATE OR REPLACE FUNCTION check_invite_pubtype_agreement () RETURNS TRIGGER AS $$
+    DECLARE
+        pub_pub_type RECORD;
+        form_pub_type RECORD;
+    BEGIN
+        IF (NEW.type != 'pub') THEN
+            RETURN NEW;
+        END IF;
+
+        SELECT pt.id, pt.name INTO pub_pub_type FROM invites
+        JOIN pubs ON invites."pubId" = pubs.id
+        JOIN pub_types pt ON pt.id = pubs."pubTypeId"
+        WHERE invites.id = NEW."inviteId";
+
+        SELECT pt.id, pt.name INTO form_pub_type
+        FROM forms JOIN pub_types pt ON pt.id = forms."pubTypeId"
+        WHERE forms.id = NEW."formId";
+
+        IF (pub_pub_type.id != form_pub_type.id) THEN
+            RAISE EXCEPTION 'Invitation failed. The specified form is for % pubs but this pub''s type is %', form_pub_type.name, pub_pub_type.name;
+        END IF;
+        RETURN NEW;
+    END;
+$$ LANGUAGE plpgsql;
+
+CREATE TRIGGER check_invite_pubtype_agreement
+AFTER INSERT ON "invite_forms" FOR EACH ROW
+EXECUTE FUNCTION check_invite_pubtype_agreement ();

core/prisma/seed.ts

@@ -8,7 +8,6 @@ import { db } from "~/kysely/database";
 import { isUniqueConstraintError } from "~/kysely/errors";
 import { createPasswordHash } from "~/lib/authentication/password";
 import { env } from "~/lib/env/env";
-import { setupInviteTestCommunity } from "./seeds/invite-test-community";
 import { seedLegacy } from "./seeds/legacy";
 import { seedStarter } from "./seeds/starter";
 
@@ -93,7 +92,7 @@ async function main() {
 
 	const legacyPromise = shouldSeedLegacy ? seedLegacy(legacyId) : null;
 
-	await Promise.all([seedStarter(starterId), legacyPromise, setupInviteTestCommunity()]);
+	await Promise.all([seedStarter(starterId), legacyPromise]);
 
 	await Promise.all([
 		createUserMembers({