Skip to content

Commit 5b57f6e

Browse files
leefaisonrbess
andauthored
Fix webdrivers issue by pinning Chrome version (#113)
* Fix webdrivers issue by pinning Chrome version Co-authored-by: Bess Sadler <[email protected]> * update Chrome version in circleci config * pin Chrome version * make browser versions match * switch to Firefox * switch to Selenium * pin Chrome version --------- Co-authored-by: Bess Sadler <[email protected]>
1 parent 8850d32 commit 5b57f6e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.circleci/config.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ commands:
2323
paths:
2424
- ~/.cache/yarn
2525
orbs:
26-
browser-tools: circleci/[email protected].1
26+
browser-tools: circleci/[email protected].3
2727
coveralls: coveralls/[email protected]
2828
jobs:
2929
build:
@@ -64,7 +64,8 @@ jobs:
6464
steps:
6565
- attach_workspace:
6666
at: *root
67-
- browser-tools/install-browser-tools
67+
- browser-tools/install-browser-tools:
68+
chrome-version: 114.0.5735.90
6869
- run:
6970
name: Wait for PostgreSQL
7071
command: dockerize -wait tcp://localhost:5432 -timeout 1m

spec/support/system_specs.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,22 @@
22

33
RSpec.configure do |config|
44
config.before(:each, type: :system) do
5+
Webdrivers::Chromedriver.required_version = '114.0.5735.90'
56
driven_by(:rack_test)
67
end
78

89
config.before(:each, type: :system, js: true) do
910
if ENV['RUN_IN_BROWSER']
10-
driven_by(:selenium_chrome)
11+
driven_by(:selenium)
1112
else
12-
driven_by(:selenium_chrome_headless)
13+
driven_by(:selenium_headless)
1314
end
1415

1516
# Make the screen larger so the save button is alway on screen. This avoids random `Element is not clickable` errors
1617
Capybara.page.driver.browser.manage.window.resize_to(2000, 2000)
1718
end
1819
config.before(:each, type: :system, js: true, in_browser: true) do
19-
driven_by(:selenium_chrome)
20+
driven_by(:selenium)
2021

2122
# Make the screen larger so the save button is alway on screen. This avoids random `Element is not clickable` errors
2223
Capybara.page.driver.browser.manage.window.resize_to(2000, 2000)

0 commit comments

Comments
 (0)