Send mail after a request is submitted, not saved (#1828)

* Send mail after a request is submitted, not saved

* Update rspec

Author: JaymeeH

Gemfile

@@ -73,7 +73,7 @@ gem "sidekiq"
 gem "whenever", require: false
 
 group :development, :test do
-  gem "rspec-rails", "~> 6.0.0"
+  gem "rspec-rails", "~> 7.0.1"
 
   gem "bixby"
   gem "byebug"

Gemfile.lock

@@ -98,7 +98,7 @@ GEM
     bcrypt_pbkdf (1.1.1-arm64-darwin)
     bcrypt_pbkdf (1.1.1-x86_64-darwin)
     benchmark (0.4.1)
-    bigdecimal (3.2.2)
+    bigdecimal (3.2.3)
     bindex (0.8.1)
     bixby (5.0.2)
       rubocop (= 1.28.2)
@@ -142,7 +142,7 @@ GEM
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.3)
+    connection_pool (2.5.4)
     coveralls_reborn (0.29.0)
       simplecov (~> 0.22.0)
       term-ansicolor (~> 1.7)
@@ -192,7 +192,7 @@ GEM
     execjs (2.10.0)
     factory_bot (6.5.5)
       activesupport (>= 6.1.0)
-    factory_bot_rails (6.5.0)
+    factory_bot_rails (6.5.1)
       factory_bot (~> 6.5)
       railties (>= 6.1.0)
     faraday (2.13.4)
@@ -204,7 +204,7 @@ GEM
     faye-websocket (0.11.4)
       eventmachine (>= 0.12.0)
       websocket-driver (>= 0.5.1, < 0.8.0)
-    ffaker (2.24.0)
+    ffaker (2.25.0)
     ffi (1.17.2-aarch64-linux-gnu)
     ffi (1.17.2-arm-linux-gnu)
     ffi (1.17.2-arm64-darwin)
@@ -222,11 +222,11 @@ GEM
     google-protobuf (3.25.8-x86-linux)
     google-protobuf (3.25.8-x86_64-darwin)
     google-protobuf (3.25.8-x86_64-linux)
-    hashdiff (1.2.0)
+    hashdiff (1.2.1)
     hashie (5.0.0)
     health-monitor-rails (12.4.0)
       railties (>= 6.1)
-    honeybadger (6.0.6)
+    honeybadger (6.1.0)
       logger
       ostruct
     i18n (1.14.7)
@@ -290,10 +290,12 @@ GEM
       uri
     net-http-persistent (4.0.6)
       connection_pool (~> 2.2, >= 2.2.4)
-    net-imap (0.5.9)
+    net-imap (0.5.10)
       date
       net-protocol
-    net-ldap (0.19.0)
+    net-ldap (0.20.0)
+      base64
+      ostruct
     net-pop (0.1.2)
       net-protocol
     net-protocol (0.2.2)
@@ -333,11 +335,11 @@ GEM
     parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
-    pg (1.6.1)
-    pg (1.6.1-aarch64-linux)
-    pg (1.6.1-arm64-darwin)
-    pg (1.6.1-x86_64-darwin)
-    pg (1.6.1-x86_64-linux)
+    pg (1.6.2)
+    pg (1.6.2-aarch64-linux)
+    pg (1.6.2-arm64-darwin)
+    pg (1.6.2-x86_64-darwin)
+    pg (1.6.2-x86_64-linux)
     popper_js (2.11.8)
     pp (0.6.2)
       prettyprint
@@ -418,7 +420,7 @@ GEM
     responders (3.1.1)
       actionpack (>= 5.2)
       railties (>= 5.2)
-    rexml (3.4.1)
+    rexml (3.4.3)
     rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.5)
@@ -427,14 +429,14 @@ GEM
     rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-rails (6.0.4)
-      actionpack (>= 6.1)
-      activesupport (>= 6.1)
-      railties (>= 6.1)
-      rspec-core (~> 3.12)
-      rspec-expectations (~> 3.12)
-      rspec-mocks (~> 3.12)
-      rspec-support (~> 3.12)
+    rspec-rails (7.0.2)
+      actionpack (>= 7.0)
+      activesupport (>= 7.0)
+      railties (>= 7.0)
+      rspec-core (~> 3.13)
+      rspec-expectations (~> 3.13)
+      rspec-mocks (~> 3.13)
+      rspec-support (~> 3.13)
     rspec-retry (0.6.2)
       rspec-core (> 3.3)
     rspec-support (3.13.5)
@@ -463,7 +465,7 @@ GEM
       rubocop (~> 1.19)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    rubyzip (3.0.2)
+    rubyzip (3.1.0)
     sassc (2.4.0)
       ffi (~> 1.9)
     sassc-rails (2.1.2)
@@ -533,7 +535,7 @@ GEM
     thread_safe (0.3.6)
     tilt (2.6.1)
     timeout (0.4.3)
-    tins (1.42.0)
+    tins (1.43.0)
       bigdecimal
       sync
     turbo-rails (2.0.16)
@@ -629,7 +631,7 @@ DEPENDENCIES
   rails (~> 7.1)
   rails-controller-testing
   redis (~> 4.0)
-  rspec-rails (~> 6.0.0)
+  rspec-rails (~> 7.0.1)
   rspec-retry
   rspec_junit_formatter
   selenium-webdriver

app/controllers/new_project_wizard/review_and_submit_controller.rb

@@ -12,6 +12,7 @@ def render_next
       if @request_model.valid_to_submit?
         @request_model.state = Request::SUBMITTED
         @request_model.save
+        TigerdataMailer.with(request_id: @request_model.id).request_creation.deliver_now
         redirect_to request_path(@request_model.id)
       else
         stubbed_message = "Please resolve errors before submitting your request"

app/controllers/request_wizards_controller.rb

@@ -36,7 +36,6 @@ def save
         # Go directly to the step the user clicked on
         redirect_to params[:commit]
       else
-        TigerdataMailer.with(request_id: @request_model.id).request_creation.deliver_now
         redirect_to "#{requests_path}/#{@request_model.id}"
       end
     end