Skip to content

Commit 5e29bc8

Browse files
authored
Fixes bug with empty users (which are valid in draft requests) (#1987)
1 parent 2ce94a9 commit 5e29bc8

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

app/presenters/request_presenter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def data_manager
2323
end
2424

2525
def full_name(uid)
26-
return "" if uid.nil?
26+
return "" if uid.blank?
2727
user = User.find_by(uid: uid)
2828
user.display_name_safe.to_s
2929
end

spec/presenters/request_presenter_spec.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,14 @@
8888
end
8989
end
9090

91+
describe "#data_manager empty" do
92+
let(:current_user) { FactoryBot.create :user }
93+
let(:request) { FactoryBot.create :request, data_manager: "" }
94+
it "handles empty users correctly" do
95+
expect(presenter.data_manager).to eq("")
96+
end
97+
end
98+
9199
describe "#full_name" do
92100
let(:current_user) { FactoryBot.create :user }
93101
it "returns the full name for a valid uid" do

0 commit comments

Comments
 (0)