Better handling for Mediaflux XML error responses (#1754)

* Better handling for Mediaflux XML error responses

* Mark a couple of tests as integration

Author: hectorcorrea

app/controllers/projects_controller.rb

@@ -152,6 +152,10 @@ def show_mediaflux
         end
       end
     end
+  rescue => ex
+    Rails.logger.error "Error getting MediaFlux XML for project #{project_id}, user #{current_user.uid}: #{ex.message}"
+    flash[:alert] = "Error fetching Mediaflux XML for this project"
+    redirect_to project_path(project_id)
   end
 
   def project_job_service

app/models/project_mediaflux.rb

@@ -10,6 +10,9 @@ class ProjectMediaflux
   def self.xml_payload(project:, user:, xml_namespace: nil)
     request = Mediaflux::AssetMetadataRequest.new(session_token: user.mediaflux_session, id: project.mediaflux_id)
     request.resolve
+    if request.error?
+      raise request.response_error[:message]
+    end
     request.response_body
   end
 

spec/models/project_mediaflux_spec.rb

@@ -96,4 +96,11 @@
       expect(project.metadata_model.updated_by).to eq "user123"
     end
   end
+
+  describe "#xml_payload" do
+    it "raises errors when project is not accessible", :integration do
+      # The project is not in mediaflux and therefore this will raise an exception
+      expect { described_class.xml_payload(project: project, user: current_user) }.to raise_error(StandardError)
+    end
+  end
 end

spec/requests/projects_spec.rb

@@ -156,20 +156,26 @@
   end
 
   describe "GET /projects/:id/:id-mf" do
-    let(:data_manager) { FactoryBot.create(:user, mediaflux_session: SystemUser.mediaflux_session) }
+    let(:data_manager) { FactoryBot.create(:user, uid: "hc8719", mediaflux_session: SystemUser.mediaflux_session) }
     let(:project) { FactoryBot.create(:approved_project, data_manager: data_manager.uid) }
 
     context "when the user is authenticated" do
       before do
+        project.approve!(current_user: sponsor_and_data_manager_user)
         sign_in data_manager
       end
 
-      it "provides the xml metadata for a project" do
-        # project/12.xml
+      it "provides the xml metadata for a project", :integration do
         get project_show_mediaflux_url(project), params: { format: :xml }
         expect(response.code).to eq "200"
         expect(response.content_type).to match "xml"
       end
+
+      it "redirect to the project page when there is an error", :integration do
+        # Go to a non-existing project to force an error
+        get project_show_mediaflux_url("non-existing"), params: { format: :xml }
+        expect(response.code).to eq "302"
+      end
     end
   end
 end