Log authentication errors (#1731)

* Log authentication errors

* Adjust test

Author: hectorcorrea

app/controllers/users/omniauth_callbacks_controller.rb

@@ -7,9 +7,11 @@ def cas
     set_cas_session
 
     if @user.nil? && access_token&.provider == "cas"
+      Rails.logger.warn "User from CAS with netid #{access_token&.uid} was not found. Provider: cas"
       redirect_to help_path
       flash.notice = "You can not be signed in at this time."
     elsif @user.nil?
+      Rails.logger.warn "User from CAS with netid #{access_token&.uid} was not found. Provider: #{access_token&.provider}"
       redirect_to root_path
       flash.alert = "You are not a recognized CAS user."
     else

spec/controllers/omniauth_callbacks_controller_spec.rb

@@ -13,9 +13,9 @@
     end
   end
 
-  context "uknown user" do
+  context "unknown user" do
     it "redirects to the help page with alert" do
-      controller.request.env["omniauth.auth"] = double(OmniAuth::AuthHash, provider: "cas")
+      controller.request.env["omniauth.auth"] = double(OmniAuth::AuthHash, provider: "cas", uid: nil)
       allow(User).to receive(:from_cas) { nil }
       get :cas
       expect(response).to redirect_to(help_path)
@@ -25,7 +25,7 @@
 
   context "non-CAS user" do
     it "redirects to the home page with alert" do
-      controller.request.env["omniauth.auth"] = double(OmniAuth::AuthHash, provider: "other")
+      controller.request.env["omniauth.auth"] = double(OmniAuth::AuthHash, provider: "other", uid: nil)
       allow(User).to receive(:from_cas) { nil }
       get :cas
       expect(response).to redirect_to(root_path)