Skip to content

Commit 88a0449

Browse files
committed
Stop passing base version when not provided
fixes #1290
1 parent 42f9634 commit 88a0449

File tree

2 files changed

+28
-21
lines changed

2 files changed

+28
-21
lines changed

CHANGES/1290.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Stop passing latest repository version on modify commands if no version number was provided.

pulp_cli/generic.py

Lines changed: 27 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1744,14 +1744,16 @@ def content_add(
17441744
content_ctx: PulpContentContext,
17451745
repo_ctx: PulpRepositoryContext,
17461746
/,
1747-
base_repository: PulpRepositoryContext,
1748-
base_version: int,
1747+
base_repository: PulpRepositoryContext | None,
1748+
base_version: int | None,
17491749
) -> None:
1750-
if base_repository is None:
1751-
base_repository = repo_ctx
1752-
base_version_ctx = base_repository.get_version_context(
1753-
-1 if base_version is None else base_version
1754-
)
1750+
base_version_ctx: PulpRepositoryVersionContext | None = None
1751+
if base_version is not None:
1752+
if base_repository is None:
1753+
base_repository = repo_ctx
1754+
base_version_ctx = base_repository.get_version_context(base_version)
1755+
elif base_repository is not None:
1756+
base_version_ctx = base_repository.get_version_context(-1)
17551757
repo_ctx.modify(add_content=[content_ctx.pulp_href], base_version=base_version_ctx)
17561758

17571759
@pulp_command("remove")
@@ -1765,15 +1767,17 @@ def content_remove(
17651767
content_ctx: PulpContentContext,
17661768
repo_ctx: PulpRepositoryContext,
17671769
/,
1768-
base_repository: PulpRepositoryContext,
1769-
base_version: int,
1770+
base_repository: PulpRepositoryContext | None,
1771+
base_version: int | None,
17701772
all: bool,
17711773
) -> None:
1772-
if base_repository is None:
1773-
base_repository = repo_ctx
1774-
base_version_ctx = base_repository.get_version_context(
1775-
-1 if base_version is None else base_version
1776-
)
1774+
base_version_ctx: PulpRepositoryVersionContext | None = None
1775+
if base_version is not None:
1776+
if base_repository is None:
1777+
base_repository = repo_ctx
1778+
base_version_ctx = base_repository.get_version_context(base_version)
1779+
elif base_repository is not None:
1780+
base_version_ctx = base_repository.get_version_context(-1)
17771781
remove_content = ["*" if all else content_ctx.pulp_href]
17781782
repo_ctx.modify(remove_content=remove_content, base_version=base_version_ctx)
17791783

@@ -1784,16 +1788,18 @@ def content_remove(
17841788
@pass_repository_context
17851789
def content_modify(
17861790
repo_ctx: PulpRepositoryContext,
1787-
base_repository: PulpRepositoryContext,
1788-
base_version: int,
1791+
base_repository: PulpRepositoryContext | None,
1792+
base_version: int | None,
17891793
add_content: list[PulpContentContext] | None,
17901794
remove_content: list[PulpContentContext] | None,
17911795
) -> None:
1792-
if base_repository is None:
1793-
base_repository = repo_ctx
1794-
base_version_ctx = base_repository.get_version_context(
1795-
-1 if base_version is None else base_version
1796-
)
1796+
base_version_ctx: PulpRepositoryVersionContext | None = None
1797+
if base_version is not None:
1798+
if base_repository is None:
1799+
base_repository = repo_ctx
1800+
base_version_ctx = base_repository.get_version_context(base_version)
1801+
elif base_repository is not None:
1802+
base_version_ctx = base_repository.get_version_context(-1)
17971803
ac = [unit.pulp_href for unit in add_content] if add_content else None
17981804
rc = [unit.pulp_href for unit in remove_content] if remove_content else None
17991805
repo_ctx.modify(add_content=ac, remove_content=rc, base_version=base_version_ctx)

0 commit comments

Comments
 (0)