Skip to content

Commit 4cf7b17

Browse files
Pin to specific node-gyp (#1608)
* Pin to specific `node-gyp` * Test removing the step entirely * Remove the step rather than just commenting it out
1 parent 2ab1509 commit 4cf7b17

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,6 @@ jobs:
134134
if: ${{ runner.os == 'Windows' }}
135135
run: (Get-Content package.json) -replace '[0-9]*-dev', (date -u +%Y%m%d%H) | Set-Content -Path package.json
136136

137-
- name: Reinstall Current Node-GYP NodeJS Headers
138-
# Overwrite bad headers that get downloaded.
139-
# NodeJS versions above 16 should come with `node-gyp@9.4.0` that has a fix
140-
# for this issue. At that point this additional step can be removed.
141-
run: npx node-gyp install ${{ env.NODE_VERSION }}
142-
143137
- name: Explicitly Specify Python Path (Windows)
144138
if: ${{ runner.os == 'Windows' }}
145139
# The Windows image somehow gets confused about which Python it should

0 commit comments

Comments
 (0)