Skip to content

Commit 9361639

Browse files
committed
CI: Split 'yarn build' and 'yarn build:apm' into separate steps
It's important that the CI job does not continue if 'yarn build' fails. The previous syntax was running 'yarn run build:apm' unconditionally after 'yarn build', regardless of exit status. So, a failure in 'yarn build' would be followed by a 'yarn run build:apm', which could succeed, and the overall CI job could proceed with broken native C/C++ addon modules (effectively a broken app!) as if nothing had failed at any point. Not good! Prevent broken app builds from passing in CI by ensuring these steps are each evaluated separately.
1 parent 487773a commit 9361639

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,21 @@ jobs:
155155
command: yarn install --ignore-engines
156156
on_retry_command: rm -R node_modules
157157

158-
- name: Build Pulsar
158+
- name: Rebuild Pulsar Dependencies for Electron
159159
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e
160160
with:
161161
timeout_minutes: 30
162162
max_attempts: 3
163163
retry_on: error
164-
command: |
165-
yarn build
166-
yarn run build:apm
164+
command: yarn build
165+
166+
- name: Build ppm
167+
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e
168+
with:
169+
timeout_minutes: 30
170+
max_attempts: 3
171+
retry_on: error
172+
command: yarn build:apm
167173

168174
- name: Cache Pulsar dependencies - Linux
169175
if: ${{ runner.os == 'Linux' }}

0 commit comments

Comments
 (0)