Commit 9361639
committed
CI: Split 'yarn build' and 'yarn build:apm' into separate steps
It's important that the CI job does not continue if 'yarn build'
fails.
The previous syntax was running 'yarn run build:apm' unconditionally
after 'yarn build', regardless of exit status. So, a failure in
'yarn build' would be followed by a 'yarn run build:apm', which
could succeed, and the overall CI job could proceed with broken
native C/C++ addon modules (effectively a broken app!) as if nothing
had failed at any point. Not good!
Prevent broken app builds from passing in CI by ensuring these steps
are each evaluated separately.1 parent 487773a commit 9361639
1 file changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
165 | | - | |
166 | | - | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
167 | 173 | | |
168 | 174 | | |
169 | 175 | | |
| |||
0 commit comments