Skip to content

Commit cf8968c

Browse files
committed
Restore deferred package tips to background-tips defaults
1 parent a1c2aa5 commit cf8968c

5 files changed

Lines changed: 3 additions & 28 deletions

File tree

packages/background-tips/lib/tips.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,7 @@ module.exports = [
22
"Split your editor into multiple panes with {pane:split-right-and-copy-active-item}",
33
"You can move lines of text up and down with {editor:move-line-up} and {editor:move-line-down}",
44
"Toggle line comments quickly with {editor:toggle-line-comments}",
5+
// Tips for deferred packages that won't register via services until activated
6+
`The Command Palette lets you access all of ${atom.branding.name}'s commands. Open it with {command-palette:toggle}`,
7+
'Dismiss panels like Find and Replace with {body>core:cancel}',
58
];

packages/command-palette/lib/command-palette-package.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,6 @@ class CommandPalettePackage {
2121
return this.commandPaletteView.show()
2222
}
2323

24-
consumeBackgroundTips (service) {
25-
const disposable = service.registerTips([
26-
`The Command Palette lets you access all of ${atom.branding.name}'s commands. Open it with {command-palette:toggle}`
27-
])
28-
this.disposables.add(disposable)
29-
return disposable
30-
}
31-
3224
async deactivate () {
3325
this.disposables.dispose()
3426
await this.commandPaletteView.destroy()

packages/command-palette/package.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,6 @@
2424
"semver": "^5.4.1",
2525
"sinon": "^3.2.1"
2626
},
27-
"consumedServices": {
28-
"background-tips": {
29-
"versions": {
30-
"1.0.0": "consumeBackgroundTips"
31-
}
32-
}
33-
},
3427
"configSchema": {
3528
"preserveLastSearch": {
3629
"type": "boolean",

packages/find-and-replace/lib/find.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -202,14 +202,6 @@ module.exports = {
202202
}
203203
},
204204

205-
consumeBackgroundTips(service) {
206-
const disposable = service.registerTips([
207-
'Dismiss panels like Find and Replace with {body>core:cancel}'
208-
]);
209-
this.subscriptions.add(disposable);
210-
return disposable;
211-
},
212-
213205
consumeAutocompleteWatchEditor(watchEditor) {
214206
this.autocompleteWatchEditor = watchEditor;
215207
atom.config.observe(

packages/find-and-replace/package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@
5555
"versions": {
5656
"1.0.0": "consumeElementIcons"
5757
}
58-
},
59-
"background-tips": {
60-
"versions": {
61-
"1.0.0": "consumeBackgroundTips"
62-
}
6358
}
6459
},
6560
"providedServices": {

0 commit comments

Comments
 (0)