It's obvious that we should be running package specs against every opened PR. I haven't done it yet because of laziness, but also because I've never written a workflow that needed action-pulsar-dependency; I might have to crib off of x-terminal-reloaded or whatever other external package uses it.
This will also be a great opportunity to dogfood action-pulsar-dependency, since this'll be the first first-party repo that depends on it.
Now that we can detect mismatches between src and lib via the build hash metadata, I'll also write a workflow job that fails CI if such a mismatch is present in someone's PR. (Once I do that, I should alter the PR template to remind contributors to commit built files.)
It's obvious that we should be running package specs against every opened PR. I haven't done it yet because of laziness, but also because I've never written a workflow that needed
action-pulsar-dependency; I might have to crib off ofx-terminal-reloadedor whatever other external package uses it.This will also be a great opportunity to dogfood
action-pulsar-dependency, since this'll be the first first-party repo that depends on it.Now that we can detect mismatches between
srcandlibvia the build hash metadata, I'll also write a workflow job that fails CI if such a mismatch is present in someone's PR. (Once I do that, I should alter the PR template to remind contributors to commit built files.)