Skip to content

Conversation

@kramhuber
Copy link
Contributor

@kramhuber kramhuber commented Dec 8, 2025

Summary

Introduces a new blog post announcing Custom Instructions and Slash Commands for Pulumi Neo

Changes

  1. Added blog post
  2. Documents how Custom Instructions automatically apply organizational standards to Neo tasks
  3. Explains how Slash Commands capture and share proven prompts across teams

@kramhuber kramhuber changed the title init neo slash commands and instructions blog/docs Dec 8, 2025
@claude
Copy link
Contributor

claude bot commented Dec 8, 2025

Review of PR #16767

I've reviewed this blog post announcement about Custom Instructions and Slash Commands for Neo. Here are my findings:

Issues Found

1. Missing newline at end of file (line 62)

The Markdown file must end with a newline character, per repository standards (AGENTS.md and STYLE-GUIDE.md).

2. Tags don't match existing conventions (frontmatter)

The post uses agentic-ai as a tag, but this doesn't appear to be an established tag in the blog. Looking at the existing Neo blog post "neo-levels-up", Neo-related posts use tags like:

  • ai
  • ai-agents
  • platform-engineering
  • pulumi-neo

Suggestion: Change agentic-ai to ai-agents to match existing conventions, or use both ai and ai-agents.

3. Missing documentation for announced features

This blog post announces two major new features (Custom Instructions and Slash Commands), but there appears to be no corresponding documentation in content/docs/ai/ for these features.

Per the review guidelines in .claude/commands/docs-review.md, when blog posts announce new Pulumi features, I should verify that documentation exists. Currently, the main AI documentation at content/docs/ai/_index.md doesn't mention Custom Instructions or Slash Commands, and I found no dedicated documentation pages for these features.

Recommendation: Before publishing this blog post, add documentation covering:

  • How to configure Custom Instructions in organization settings
  • What Custom Instructions can contain (with examples)
  • How to create custom Slash Commands
  • How to use built-in Slash Commands
  • Parameter handling for Slash Commands

Suggested location: content/docs/ai/custom-instructions/ and content/docs/ai/slash-commands/ (or combine into a single guide)

4. Future date in frontmatter (line 4)

The post has date: 2025-12-10 which is in the future (today is 2025-12-08). This is fine if intentional for scheduled publishing, but note that Hugo doesn't automatically publish on that date—deployment happens on merge to master per BLOGGING.md.

Style and Content Notes

Good:

  • Title follows proper Title Case for H1
  • Meta description is clear and within appropriate length
  • Good use of <!--more--> break after opening paragraph
  • Headings use proper sentence case
  • Clear, concise writing that avoids jargon
  • Good use of table for built-in commands
  • Strong structure with clear sections
  • Includes proper call-to-action at end

Writing quality:

  • Opening effectively explains the problem these features solve
  • Before/after example clearly demonstrates value
  • Examples are concrete and realistic
  • No unnecessary filler or vague generalities

Minor Observations

  • The phrase "no coding required" (line 58) is good—clear and specific
  • Good that draft is set to true (line 6)
  • The table formatting is clean and readable
  • Meta image file is included (didn't check content/quality as it's binary)

Action Items

Must fix before merge:

  1. ✅ Add newline at end of index.md
  2. ⚠️ Consider changing agentic-ai tag to match existing conventions

Strongly recommended:
3. 📚 Add corresponding documentation pages for Custom Instructions and Slash Commands before publishing this announcement

Verify:
4. 📅 Confirm the 2025-12-10 date is intentional for scheduled publishing


Overall, this is a well-written blog post with clear value proposition and good structure. The main concern is the missing documentation—announcing features without corresponding docs can frustrate users who want to try them.

@claude Mention me if you need help creating the documentation or want another review after addressing these items.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@kramhuber
Copy link
Contributor Author

@claude please review again

@claude
Copy link
Contributor

claude bot commented Dec 9, 2025

Claude finished @kramhuber's task —— View job


Re-review of PR #16767

I've reviewed the updated blog post and new documentation. Great work addressing the previous feedback! Here's what I found:


✅ Previous Issues Resolved

  1. Missing newline at end of file: ✅ Fixed - The blog post now ends with a newline (line 67)

  2. Tags don't match conventions: ✅ Fixed - Changed from agentic-ai to the established tags:

    • ai
    • ai-agents
    • platform-engineering
    • pulumi-neo
  3. Missing documentation: ✅ Fixed - Added comprehensive documentation at content/docs/ai/settings/_index.md covering:

    • Neo Access controls
    • Custom Instructions with examples and best practices
    • Slash Commands (built-in and custom)
    • Task Modes
  4. Future date: Still present (2025-12-10) - This appears intentional for scheduled publishing


📝 New Documentation Review

The new content/docs/ai/settings/_index.md file is well-structured and comprehensive:

Strengths:

  • Clear organization with proper heading hierarchy (H2 for main sections)
  • Good use of tables for listing commands
  • Includes practical examples (Custom Instructions example is concrete and helpful)
  • Best practices sections for each feature
  • Proper Hugo shortcode usage ({{% notes type="info" %}})
  • All headings follow proper capitalization (Title Case for title, Sentence case for H2+)
  • File ends with newline ✅

Content Quality:

  • Instructions are clear and actionable
  • Step-by-step configuration instructions are easy to follow
  • Good balance between explaining what features do and how to use them
  • Task Modes section provides clear differentiation between the three modes

📋 Blog Post Review

The blog post is well-written and effectively communicates the value of both features:

Strengths:

  • Strong opening that establishes the problem these features solve
  • Clear before/after example showing the impact of Custom Instructions
  • Good use of the `` break for proper excerpt handling
  • Table for built-in commands is clean and readable
  • Effective call-to-action with links to documentation
  • Proper heading capitalization throughout
  • File ends with newline ✅

Content Quality:

  • Writing is concise and avoids unnecessary filler
  • Examples are realistic and relatable
  • Clear explanation of how Slash Commands work
  • Good GIF demonstrating the feature in action

✅ Style Guide Compliance

Checked against AGENTS.md and style requirements:

  • ✅ Markdown formatting is standard
  • ✅ All files end with newlines
  • ✅ H1 uses Title Case
  • ✅ H2+ use Sentence case
  • ✅ Proper use of lowercase for non-proper nouns
  • ✅ No spelling or grammar errors detected
  • ✅ Links are properly formatted

🎯 Summary

This PR is ready to merge. All previous feedback has been addressed:

  • Documentation now exists for the announced features
  • Tag conventions are followed
  • Style guide compliance is maintained
  • File formatting is correct

The blog post effectively announces the features, and the documentation provides the depth users need to implement them. The 2025-12-10 date appears intentional for scheduled publishing, which is appropriate.

Recommendation: Approve and merge when ready to publish.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants