fixing tests and adding todos

Author: corymhall

examples/examples_nodejs_test.go

@@ -595,6 +595,9 @@ func TestRegress2868(t *testing.T) {
 	test := getJSBaseOptions(t).
 		With(integration.ProgramTestOptions{
 			Dir: filepath.Join(getCwd(t), "regress-2868"),
+			// TODO[pulumi/pulumi-aws#5521] `region` causes permanent diff without refresh
+			PreviewCommandlineFlags: []string{"--refresh"},
+			UpdateCommandlineFlags:  []string{"--refresh"},
 		})
 	// Disable envRegion mangling
 	test.Config = nil

examples/examples_yaml_test.go

@@ -1409,13 +1409,47 @@ func TestRegressUnknownTags(t *testing.T) {
 func TestWrongStateMaxItemOneDiffProduced(t *testing.T) {
 	repro := `
 	[
+		{
+			"method": "/pulumirpc.ResourceProvider/Configure",
+			"request": {
+				"variables": {
+					"aws:config:region": "us-east-1",
+					"aws:config:skipCredentialsValidation": "true",
+					"aws:config:skipRegionValidation": "true"
+				},
+				"args": {
+					"region": "us-east-1",
+					"skipCredentialsValidation": "true",
+					"skipRegionValidation": "true",
+					"version": "7.0.0-alpha.0+dev"
+				},
+				"acceptSecrets": true,
+				"acceptResources": true,
+				"sendsOldInputs": true,
+				"sendsOldInputsToDelete": true,
+				"id": "8043d035-cb0a-40bb-9479-34f237a486d2",
+				"urn": "urn:pulumi:dev::aws_esm_py::pulumi:providers:aws::default_7_0_0_alpha_0_dev",
+				"name": "default_7_0_0_alpha_0_dev",
+				"type": "pulumi:providers:aws"
+			},
+			"response": {
+				"supportsPreview": true,
+				"supportsAutonamingConfiguration": true
+			},
+			"metadata": {
+				"kind": "resource",
+				"mode": "client",
+				"name": "aws"
+			}
+		},
     {
       "method": "/pulumirpc.ResourceProvider/Diff",
       "request": {
           "id": "f8af893f-869e-4861-a403-1a4fe3509754",
           "urn": "urn:pulumi:dev::aws_esm_py::aws:lambda/eventSourceMapping:EventSourceMapping::example",
           "olds": {
               "amazonManagedKafkaEventSourceConfig": null,
+							"region": "us-east-1",
               "batchSize": 10,
               "bisectBatchOnFunctionError": false,
               "destinationConfig": null,
@@ -1451,6 +1485,7 @@ func TestWrongStateMaxItemOneDiffProduced(t *testing.T) {
               "__defaults": [
                   "enabled"
               ],
+							"region": "us-east-1",
               "enabled": true,
               "eventSourceArn": "arn:aws:sqs:us-east-1:616138583583:queue-7798098",
 							"tagsAll": {},
@@ -1460,6 +1495,7 @@ func TestWrongStateMaxItemOneDiffProduced(t *testing.T) {
               "__defaults": [
                   "enabled"
               ],
+							"region": "us-east-1",
               "enabled": true,
               "eventSourceArn": "arn:aws:sqs:us-east-1:616138583583:queue-7798098",
               "functionName": "arn:aws:lambda:us-east-1:616138583583:function:testLambda-74dac89"

provider/diff_test.go

@@ -27,6 +27,7 @@ import (
 //
 // See also pulumi/pulumi-aws#3650.
 func TestRegressLandingZoneDiff(t *testing.T) {
+	// TODO[pulumi/pulumi-aws#5518]
 	t.Skip("Skipping for now")
 	t.Parallel()
 
@@ -72,6 +73,7 @@ func TestRegressLandingZoneDiff(t *testing.T) {
 }
 
 func TestRegress1738(t *testing.T) {
+	// TODO[pulumi/pulumi-aws#5518]
 	t.Skip("Skipping for now")
 	t.Parallel()