fix: drop t.Parallel() from dynamic tests that now use t.Setenv via Integration(t)

t.Setenv and t.Parallel are mutually exclusive on the same *testing.T regardless of call order (Go panics either way), not just when Setenv follows Parallel as previously assumed. TestSDKv1Provider, TestConflictsWithNamePrefixOnly, TestConflictsWithBothUserSpecified, and TestRandomCreate all call Integration(t) (or t.Setenv directly), which now sets an env var, so they can no longer also call t.Parallel().

Author: pierskarsenbarg

dynamic/conflicting_test.go

@@ -19,10 +19,10 @@ import (
 var conflictsProviderPath = helper.BuildOnce(&globalTempDir,
 	"test/conflictsprovider", "terraform-provider-conflictsprovider")
 
-func TestConflictsWithNamePrefixOnly(t *testing.T) {
-	// helper.Integration(t) now calls t.Setenv, which must happen before t.Parallel().
+func TestConflictsWithNamePrefixOnly(t *testing.T) { //nolint:paralleltest
+	// helper.Integration(t) now calls t.Setenv. t.Setenv and t.Parallel are mutually
+	// exclusive on the same test, so this cannot be parallel.
 	helper.Integration(t)
-	t.Parallel()
 	skipWindows(t)
 
 	server := parameterizedTestServer(t, conflictsProviderPath)
@@ -55,10 +55,10 @@ func TestConflictsWithNamePrefixOnly(t *testing.T) {
 // When the user explicitly supplies both `name` and `name_prefix`, the bridge
 // must surface the upstream ConflictsWith error rather than silently dropping
 // one of the user-provided values.
-func TestConflictsWithBothUserSpecified(t *testing.T) {
-	// helper.Integration(t) now calls t.Setenv, which must happen before t.Parallel().
+func TestConflictsWithBothUserSpecified(t *testing.T) { //nolint:paralleltest
+	// helper.Integration(t) now calls t.Setenv. t.Setenv and t.Parallel are mutually
+	// exclusive on the same test, so this cannot be parallel.
 	helper.Integration(t)
-	t.Parallel()
 	skipWindows(t)
 
 	server := parameterizedTestServer(t, conflictsProviderPath)

dynamic/provider_test.go

@@ -723,10 +723,9 @@ func TestSchemaGenerationIndexDocOutDir(t *testing.T) { //nolint:paralleltest
 
 func TestRandomCreate(t *testing.T) {
 	// This test relies on live registry acquisition, so it must not inherit
-	// PULUMI_DISABLE_AUTOMATIC_PLUGIN_ACQUISITION from the environment. Must be set
-	// before t.Parallel(), since t.Setenv panics once a test is marked parallel.
+	// PULUMI_DISABLE_AUTOMATIC_PLUGIN_ACQUISITION from the environment. t.Setenv and
+	// t.Parallel are mutually exclusive on the same test, so this cannot be parallel.
 	t.Setenv("PULUMI_DISABLE_AUTOMATIC_PLUGIN_ACQUISITION", "false")
-	t.Parallel()
 	ctx := context.Background()
 	server := grpcTestServer(ctx, t)
 	parameterizeResp, err := server.Parameterize(ctx, &pulumirpc.ParameterizeRequest{
@@ -787,10 +786,10 @@ func TestRandomCreate(t *testing.T) {
 	})
 }
 
-func TestSDKv1Provider(t *testing.T) {
-	// helper.Integration(t) now calls t.Setenv, which must happen before t.Parallel().
+func TestSDKv1Provider(t *testing.T) { //nolint:paralleltest
+	// helper.Integration(t) now calls t.Setenv. t.Setenv and t.Parallel are mutually
+	// exclusive on the same test, so this cannot be parallel.
 	helper.Integration(t)
-	t.Parallel()
 	skipWindows(t)
 
 	server := parameterizedTestServer(t, sdkv1ProviderPath)