Skip to content

Commit db61828

Browse files
use accurate bridge preview flag for all diff tests
1 parent 3f39263 commit db61828

File tree

5 files changed

+21
-9
lines changed

5 files changed

+21
-9
lines changed

pkg/pf/tests/genrandom_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ func TestGenRandom(t *testing.T) {
4848

4949
t.Run(trace, func(t *testing.T) {
5050
p := testprovider.RandomProvider()
51+
p.EnableAccurateBridgePreview = true
5152
server, err := newProviderServer(t, p)
5253
require.NoError(t, err)
5354
testutils.ReplayFile(t, server, trace)

pkg/pf/tests/genupdate_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ func TestGenUpdates(t *testing.T) {
3434
t.Parallel()
3535
trace := "testdata/updateprogram.json"
3636

37-
server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
37+
info := testprovider.SyntheticTestBridgeProvider()
38+
info.EnableAccurateBridgePreview = true
39+
server, err := newProviderServer(t, info)
3840
require.NoError(t, err)
3941
testutils.ReplayFile(t, server, trace)
4042
}

pkg/pf/tests/internal/cross-tests/diff.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func Diff(t T, res pb.Resource, tfConfig1, tfConfig2 map[string]cty.Value, optio
109109
require.NoError(t, err)
110110
t.Logf("Pulumi.yaml:\n%s", string(bytes))
111111

112-
pt, err := pulcheck.PulCheck(t, bridgedProvider(prov), string(bytes))
112+
pt, err := pulcheck.PulCheck(t, bridgedProvider(prov, bridgedProviderOpts{enableAccurateBridgePreview: true}), string(bytes))
113113
require.NoError(t, err)
114114
pt.Up(t)
115115

pkg/pf/tests/internal/cross-tests/util.go

+10-5
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,19 @@ func skipUnlessLinux(t T) {
5858
}
5959
}
6060

61-
func bridgedProvider(prov *providerbuilder.Provider) info.Provider {
61+
type bridgedProviderOpts struct {
62+
enableAccurateBridgePreview bool
63+
}
64+
65+
func bridgedProvider(prov *providerbuilder.Provider, opts bridgedProviderOpts) info.Provider {
6266
shimProvider := tfbridge.ShimProvider(prov)
6367

6468
provider := tfbridge0.ProviderInfo{
65-
P: shimProvider,
66-
Name: prov.TypeName,
67-
Version: prov.Version,
68-
MetadataInfo: &tfbridge0.MetadataInfo{},
69+
P: shimProvider,
70+
Name: prov.TypeName,
71+
Version: prov.Version,
72+
MetadataInfo: &tfbridge0.MetadataInfo{},
73+
EnableAccurateBridgePreview: opts.enableAccurateBridgePreview,
6974
}
7075

7176
provider.MustComputeTokens(tokens.SingleModule(prov.TypeName, "index", tokens.MakeStandard(prov.TypeName)))

pkg/pf/tests/provider_diff_test.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ func TestEmptyTestresDiff(t *testing.T) {
5656
// Test removing an optional input.
5757
func TestOptionRemovalTestresDiff(t *testing.T) {
5858
t.Parallel()
59-
server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
59+
info := testprovider.SyntheticTestBridgeProvider()
60+
info.EnableAccurateBridgePreview = true
61+
server, err := newProviderServer(t, info)
6062
require.NoError(t, err)
6163
testCase := `
6264
{
@@ -270,7 +272,9 @@ func TestSetNestedObjectAdded(t *testing.T) {
270272

271273
func TestSetNestedObjectAddedOtherDiff(t *testing.T) {
272274
t.Parallel()
273-
server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
275+
info := testprovider.SyntheticTestBridgeProvider()
276+
info.EnableAccurateBridgePreview = true
277+
server, err := newProviderServer(t, info)
274278
require.NoError(t, err)
275279
testCase := `
276280
{

0 commit comments

Comments
 (0)