Fix tags not being properly displayed

Author: pupi1985

qa_hashtagger.php

@@ -26,6 +26,16 @@ class qa_hashtagger
      */
     private static $notification;
 
+    /**
+     * The list of tags to set to the question
+     *
+     * @var array
+     */
+    private static $questionTags;
+
+    /** @var bool */
+    private static $newTagsPresent = false;
+
     /**
      * Filter question
      *
@@ -169,12 +179,12 @@ private function set_notification($question, $oldrow, $type)
      */
     private function set_question_tags($question)
     {
-        if (self::$hashtags) {
+        if (!empty(self::$questionTags)) {
             if (isset($question['tags'])) {
-                $new_tags = array_merge($question['tags'], self::$hashtags);
+                $new_tags = array_merge($question['tags'], self::$questionTags);
                 $question['tags'] = array_unique($new_tags);
             } else {
-                $question['tags'] = self::$hashtags;
+                $question['tags'] = self::$questionTags;
             }
         }
 
@@ -210,26 +220,40 @@ private function show_html_links($match)
     /**
      * Build tag link and set it for global variable
      *
-     * @param array $match
+     * @param array $matches
+     * @param boolean $htmlFormat
      *
      * @return string
      */
-    private static function build_tag_link($match)
+    private static function build_tag_link(array $matches, $htmlFormat)
     {
         require_once QA_INCLUDE_DIR . 'util/string.php';
+        require_once QA_INCLUDE_DIR . 'db/post-create.php';
+
+        $tag = qa_strtolower($matches['word']);
 
-        $tag = qa_strtolower($match['word']);
+        if ($htmlFormat) {
+            $tag = html_entity_decode($tag);
+        }
 
         $linkText = qa_opt('plugin_hashtagger/keep_hash_symbol') ? "#" : '';
         $linkText .= $tag;
 
-        if (!in_array($tag, self::$hashtags)) {
-            self::$hashtags[] = $tag;
+        $tagWord = qa_db_single_select(qa_db_tag_word_selectspec($tag));
+
+        self::$questionTags[] = $tag;
+
+        if (is_null($tagWord)) {
+            $tagWord = qa_db_word_mapto_ids_add(array($tagWord));
         }
 
         $url = qa_html(qa_path_absolute('tag/' . $tag));
 
-        return sprintf('<a href="%s">%s</a>', $url, $linkText);
+        if (!in_array($tag, self::$hashtags)) {
+            self::$hashtags[$tagWord['wordid']] = $url;
+        }
+
+        return sprintf('${hashtagger-open-link-tag-%s}%s${hashtagger-close-link}', $tagWord['wordid'], $linkText);
     }
 
     /**
@@ -240,13 +264,12 @@ private static function build_tag_link($match)
      *
      * @return string
      */
-    private static function build_user_link($match, $htmlFormat)
+    private static function build_user_link(array $match, $htmlFormat)
     {
         $handle = $match['name'];
 
         if ($htmlFormat) {
             $handle = html_entity_decode($handle);
-            echo $handle;
         }
 
         $userid = qa_handle_to_userid($handle);
@@ -313,6 +336,7 @@ private function init_filter(&$row, $type)
         // Redefine variables
         self::$hashtags = array();
         self::$userids = array();
+        self::$questionTags = array();
 
         $htmlContent = $row['content'];
         $isInHtmlFormat = $row['format'] === 'html';
@@ -324,18 +348,12 @@ private function init_filter(&$row, $type)
 
         // Convert hashtags
         if ($convert_hashtags) {
-            $htmlContent = $this->preg_call('%#(?P<word>[\w\-]+?)#%u', 'build_tag_link', $htmlContent);
+            $htmlContent = $this->parseTags($isInHtmlFormat, $htmlContent);
         }
 
         // Convert usernames
         if ($convert_usernames) {
-            $htmlContent = preg_replace_callback(
-                '%@(?P<name>.+?)[@/+]%u',
-                function ($matches) use ($isInHtmlFormat) {
-                    return self::build_user_link($matches, $isInHtmlFormat);
-                },
-                $htmlContent
-            );
+            $htmlContent = $this->parseUsers($isInHtmlFormat, $htmlContent);
         }
 
         // Unhide links
@@ -351,17 +369,94 @@ function ($matches) use ($isInHtmlFormat) {
             $htmlContent = qa_html($htmlContent, true);
         }
 
+        $htmlContent = $this->updateUsers($htmlContent);
+        $htmlContent = $this->updateTags($htmlContent);
+        $htmlContent = $this->updateCloseTags($htmlContent);
+
+        // Let's force the object to use HTML format if it has created links
+        if (!$isInHtmlFormat) {
+            $row['format'] = 'html';
+        }
+        $row['content'] = $htmlContent;
+    }
+
+    /**
+     * @param bool $isInHtmlFormat
+     * @param string $htmlContent
+     *
+     * @return string
+     */
+    private function parseTags($isInHtmlFormat, $htmlContent)
+    {
+        $htmlContent = preg_replace_callback(
+            '%#(?P<word>[\w\-]+?)#%u',
+            function ($matches) use ($isInHtmlFormat) {
+                return self::build_tag_link($matches, $isInHtmlFormat);
+            },
+            $htmlContent
+        );
+
+        return $htmlContent;
+    }
+
+    /**
+     * @param bool $isInHtmlFormat
+     * @param string $htmlContent
+     *
+     * @return string
+     */
+    private function parseUsers($isInHtmlFormat, $htmlContent)
+    {
+        $htmlContent = preg_replace_callback(
+            '%@(?P<name>.+?)[@/+]%u',
+            function ($matches) use ($isInHtmlFormat) {
+                return self::build_user_link($matches, $isInHtmlFormat);
+            },
+            $htmlContent
+        );
+
+        return $htmlContent;
+    }
+
+    /**
+     * @param string $htmlContent
+     *
+     * @return string
+     */
+    private function updateUsers($htmlContent)
+    {
         foreach (self::$userids as $userid => $url) {
             $openLinkSearch = sprintf('${hashtagger-open-link-user-%s}', $userid);
             $replaceWith = sprintf('<a href="%s">', $url);
             $htmlContent = str_replace($openLinkSearch, $replaceWith, $htmlContent);
         }
-        $htmlContent = str_replace('${hashtagger-close-link}', '</a>', $htmlContent);
 
-        // Let's force the object to use HTML format if it has created links
-        if (!$isInHtmlFormat) {
-            $row['format'] = 'html';
+        return $htmlContent;
+    }
+
+    /**
+     * @param string $htmlContent
+     *
+     * @return string
+     */
+    public function updateTags($htmlContent)
+    {
+        foreach (self::$hashtags as $tagId => $url) {
+            $openLinkSearch = sprintf('${hashtagger-open-link-tag-%s}', $tagId);
+            $replaceWith = sprintf('<a href="%s">', $url);
+            $htmlContent = str_replace($openLinkSearch, $replaceWith, $htmlContent);
         }
-        $row['content'] = $htmlContent;
+
+        return $htmlContent;
+    }
+
+    /**
+     * @param $htmlContent
+     *
+     * @return string
+     */
+    public function updateCloseTags($htmlContent)
+    {
+        return str_replace('${hashtagger-close-link}', '</a>', $htmlContent);
     }
 }

qa_hashtagger_lang_default.php

@@ -6,9 +6,9 @@
     'filter_questions' => 'Handle questions',
     'filter_comments' => 'Handle comments',
     'filter_answers' => 'Handle answers',
-    'convert_hashtags' => 'Enable hashtags (convert <i>#some_word</i> to tag link)',
+    'convert_hashtags' => 'Enable hashtags (convert <i>#some_word#</i> to tag link)',
     'keep_hash_symbol' => 'Keep "#" symbol for tags names',
-    'convert_usernames' => 'Enable mentions (convert <i>@some_name</i> to user profile link)',
+    'convert_usernames' => 'Enable mentions (convert <i>@some_name@</i> to user profile link)',
     'notify_users' => 'Notify the user when it is mentioned',
     'user_mentioned_title' => 'You have been mentioned on "^site_title"',
     'user_mentioned_body' => '^author_name mentioned you on his message: ^mentioned_url',