Skip to content

Commit 0dd479b

Browse files
committed
(MAINT) Full linter fix
1 parent 312a4d4 commit 0dd479b

File tree

19 files changed

+464
-220
lines changed

19 files changed

+464
-220
lines changed

.jshintrc

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
{
2-
"predef": [
3-
"document",
4-
"window",
5-
"-Promise"
6-
],
2+
"predef": ["document", "window", "-Promise"],
73
"browser": true,
84
"boss": true,
95
"curly": true,

AUTHORS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
["Dray Lacy", "Nathaniel Bibler", "Yoran Brondsema", "Jonathan Newman", "Steven Foote", "Manuel Wiedenmann", "Katlin Anderson"]
1+
["Dray Lacy", "Nathaniel Bibler", "Yoran Brondsema", "Jonathan Newman", "Steven Foote", "Manuel Wiedenmann", "Katlin Anderson"]

CHANGELOG.md

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -6,141 +6,141 @@ All notable changes to this project will be documented in this file. See [standa
66

77
### Security
88

9-
* Bump jquery from 3.3.1 to 3.4.0 ([05c21dd](https://github.com/IvyApp/ivy-tabs/commit/05c21dd))
9+
- Bump jquery from 3.3.1 to 3.4.0 ([05c21dd](https://github.com/IvyApp/ivy-tabs/commit/05c21dd))
1010

1111
## [3.3.0][] / 2018-03-17
1212

13-
* Add "aria-live" to tablists for reporting tab changes to the user.
14-
* Add optional "aria-label" to tablists to improve screenreader reporting.
15-
* Give active tabpanels tabindex 0 to allow keyboard navigation to the active panel content.
16-
* Use a temporary "presentation" role for tablists until tabs are inserted and the "tablist" role is then allowed. See emberjs/ember.js#16379.
13+
- Add "aria-live" to tablists for reporting tab changes to the user.
14+
- Add optional "aria-label" to tablists to improve screenreader reporting.
15+
- Give active tabpanels tabindex 0 to allow keyboard navigation to the active panel content.
16+
- Use a temporary "presentation" role for tablists until tabs are inserted and the "tablist" role is then allowed. See emberjs/ember.js#16379.
1717

1818
## [3.2.0][] / 2018-03-07
1919

20-
* No longer trigger selection actions during Component destruction.
21-
* [#33](https://github.com/IvyApp/ivy-tabs/pull/33) Remove jQuery usage. Thanks to @smfoote and @dxprog.
22-
* [#37](https://github.com/IvyApp/ivy-tabs/pull/37) Move to modules API. Thanks to @sutori.
20+
- No longer trigger selection actions during Component destruction.
21+
- [#33](https://github.com/IvyApp/ivy-tabs/pull/33) Remove jQuery usage. Thanks to @smfoote and @dxprog.
22+
- [#37](https://github.com/IvyApp/ivy-tabs/pull/37) Move to modules API. Thanks to @sutori.
2323

2424
## [3.1.0][] / 2016-12-02
2525

26-
* [#32](https://github.com/IvyApp/ivy-tabs/pull/32) Add Ember 2.10 support.
26+
- [#32](https://github.com/IvyApp/ivy-tabs/pull/32) Add Ember 2.10 support.
2727

2828
## [3.0.2][] / 2016-10-14
2929

30-
* Remove `throw` when a tab is not found by index or model. Add "dynamic tabs" example page to the dummy app.
31-
* Switch from globals to modules.
30+
- Remove `throw` when a tab is not found by index or model. Add "dynamic tabs" example page to the dummy app.
31+
- Switch from globals to modules.
3232

3333
## [3.0.1][] / 2016-10-12
3434

35-
* [#25](https://github.com/IvyApp/ivy-tabs/issues/25) Fix a deprecation warning when tab panels are defined before the tab list.
35+
- [#25](https://github.com/IvyApp/ivy-tabs/issues/25) Fix a deprecation warning when tab panels are defined before the tab list.
3636

3737
## [3.0.0][] / 2016-08-31
3838

3939
**This release introduces several breaking changes from the 2.x series.** Refer
4040
to the README for current usage.
4141

42-
* [#24](https://github.com/IvyApp/ivy-tabs/pull/24) "Namespace" components under `ivy-tabs-*`
43-
* [#23](https://github.com/IvyApp/ivy-tabs/pull/23) Remove `tagName` values except for tabs, which are now anchor tags by default.
44-
* [#21](https://github.com/IvyApp/ivy-tabs/pull/21) Select tabs by a (now required) model value, rather than tab index.
45-
* Rename `selectedIndex` on `ivy-tabs` to `selection`.
46-
* Move `on-select` action from `ivy-tabs` to individual tabs.
47-
* [#22](https://github.com/IvyApp/ivy-tabs/pull/22) Remove isVisible manipulation and rely on application styles for presentation management.
42+
- [#24](https://github.com/IvyApp/ivy-tabs/pull/24) "Namespace" components under `ivy-tabs-*`
43+
- [#23](https://github.com/IvyApp/ivy-tabs/pull/23) Remove `tagName` values except for tabs, which are now anchor tags by default.
44+
- [#21](https://github.com/IvyApp/ivy-tabs/pull/21) Select tabs by a (now required) model value, rather than tab index.
45+
- Rename `selectedIndex` on `ivy-tabs` to `selection`.
46+
- Move `on-select` action from `ivy-tabs` to individual tabs.
47+
- [#22](https://github.com/IvyApp/ivy-tabs/pull/22) Remove isVisible manipulation and rely on application styles for presentation management.
4848

4949
## [2.0.0][] / 2016-04-17
5050

5151
**This release drops support for Ember < 2.3.**
5252

53-
* [#13](https://github.com/IvyApp/ivy-tabs/pull/13) Data down, Actions up.
54-
* [#15](https://github.com/IvyApp/ivy-tabs/pull/15) Add aria-hidden to ivy-tab-panel.
55-
* [#12](https://github.com/IvyApp/ivy-tabs/pull/12) Convert to contextual components.
56-
* Upgrade to Ember CLI 2.5.0.
53+
- [#13](https://github.com/IvyApp/ivy-tabs/pull/13) Data down, Actions up.
54+
- [#15](https://github.com/IvyApp/ivy-tabs/pull/15) Add aria-hidden to ivy-tab-panel.
55+
- [#12](https://github.com/IvyApp/ivy-tabs/pull/12) Convert to contextual components.
56+
- Upgrade to Ember CLI 2.5.0.
5757

5858
## [1.2.0][] / 2016-03-24
5959

60-
* Upgrade `ember-cli` to 2.4.2.
61-
* Use block params instead of `parentView`.
62-
* Remove index file.
63-
* Remove standalone builds.
64-
* Select the next tab when the active, first tab is removed.
65-
* Retain tab selection if a preceding tab is removed.
60+
- Upgrade `ember-cli` to 2.4.2.
61+
- Use block params instead of `parentView`.
62+
- Remove index file.
63+
- Remove standalone builds.
64+
- Select the next tab when the active, first tab is removed.
65+
- Retain tab selection if a preceding tab is removed.
6666

6767
## [1.1.0][] / 2015-05-21
6868

69-
* Upgrade addon to ember-cli 0.2.4.
70-
* Fix an issue with initial value of `selected-index` not being applied.
71-
* Add touch support.
72-
* Upgrade to ember-cli 0.2.0.
73-
* Upgrade to ember 1.10.0.
69+
- Upgrade addon to ember-cli 0.2.4.
70+
- Fix an issue with initial value of `selected-index` not being applied.
71+
- Add touch support.
72+
- Upgrade to ember-cli 0.2.0.
73+
- Upgrade to ember 1.10.0.
7474

7575
## [1.0.0][] / 2015-02-19
7676

77-
* Ensure selected-index remains 0 if all tabs are removed.
78-
* Upgrade to ember-cli 0.1.5.
79-
* Upgrade to ember 1.9.1 in dummy app.
80-
* Remove unnecessary ember-data dependency in dummy app.
81-
* Remove version suffix from ivy-tabs.js.
82-
* More tooling changes. Should now be usable as a Bower package, outside of an
77+
- Ensure selected-index remains 0 if all tabs are removed.
78+
- Upgrade to ember-cli 0.1.5.
79+
- Upgrade to ember 1.9.1 in dummy app.
80+
- Remove unnecessary ember-data dependency in dummy app.
81+
- Remove version suffix from ivy-tabs.js.
82+
- More tooling changes. Should now be usable as a Bower package, outside of an
8383
Ember CLI app.
84-
* Remove deprecated selectedIndex property.
85-
* Convert to an ember-cli addon.
86-
* Rename toplevel global from `ivy.tabs` to `IvyTabs`.
84+
- Remove deprecated selectedIndex property.
85+
- Convert to an ember-cli addon.
86+
- Rename toplevel global from `ivy.tabs` to `IvyTabs`.
8787

8888
## [0.3.0][] / 2014-11-05
8989

90-
* Move away from `broccoli-dist-es6-module`. Instead, use
90+
- Move away from `broccoli-dist-es6-module`. Instead, use
9191
`broccoli-es6-module-transpiler`, which supports the latest version of the
9292
ES6 module transpiler. Rather than generating separate distributions for
9393
`amd`, `cjs`, `named-amd` and `globals`, we now output a single "bundle"
9494
format.
95-
* Deprecate `selectedIndex`, use `selected-index` instead.
95+
- Deprecate `selectedIndex`, use `selected-index` instead.
9696

9797
## [0.2.0][] / 2014-11-03
9898

99-
* Add keyboard navigation.
99+
- Add keyboard navigation.
100100

101101
## [0.1.6][] / 2014-11-04
102102

103-
* Build tooling changes.
103+
- Build tooling changes.
104104

105105
## [0.1.5][] / 2014-11-03
106106

107-
* Fix issue with tab index being out of order. This was being caused by
107+
- Fix issue with tab index being out of order. This was being caused by
108108
a reliance on `didInsertElement` firing in a particular order, which Ember
109109
doesn't guarantee. Instead, the actions are now fired inside the `init` and
110110
`willDestroy` methods of the component classes.
111111

112112
## [0.1.4][] / 2014-11-01
113113

114-
* Fix incorrect spelling of "aria-labelledby".
114+
- Fix incorrect spelling of "aria-labelledby".
115115

116116
## [0.1.3][] / 2014-11-01
117117

118-
* Rewrite internals to make selectedIndex canonical. Previously, the "active
118+
- Rewrite internals to make selectedIndex canonical. Previously, the "active
119119
tab" object was canonical, and the selectedIndex was calculated based on this
120120
tab's index in the tabs array. That has been flipped on its head so now, the
121121
"selected tab" is calculated based on the selectedIndex.
122-
* Replace use of `Ember.computed.readOnly`. This method didn't exist prior to
122+
- Replace use of `Ember.computed.readOnly`. This method didn't exist prior to
123123
Ember 1.5.
124-
* Change "aria-expanded" to a read-only alias.
124+
- Change "aria-expanded" to a read-only alias.
125125

126126
## [0.1.2][] / 2014-10-30
127127

128-
* When active tab is removed, select the previous tab (if any).
128+
- When active tab is removed, select the previous tab (if any).
129129

130130
## [0.1.1][] / 2014-10-23
131131

132-
* Ensure `ivy-tab-panel`'s `isVisible` property is a Boolean. Previously it was
132+
- Ensure `ivy-tab-panel`'s `isVisible` property is a Boolean. Previously it was
133133
an alias to `active`, which returns a String so that it can be used as
134134
a classname binding. The problem is, Ember observes `isVisible` and calls
135135
jQuery's `toggle` function while passing in the value of `isVisible` to
136-
determine whether to show or hide the element. In this case, `isVisible` was
136+
determine whether to show or hide the element. In this case, `isVisible` was
137137
returning a String, which jQuery would interpret as an easing function. This
138138
would result in the tab panels animating in and out when switching between
139139
tabs.
140140

141141
## [0.1.0][] / 2014-10-23
142142

143-
* Initial release.
143+
- Initial release.
144144

145145
[0.1.0]: https://github.com/IvyApp/ivy-tabs/tree/v0.1.0
146146
[0.1.1]: https://github.com/IvyApp/ivy-tabs/compare/v0.1.0...v0.1.1

CODE_OF_CONDUCT.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,26 @@ We want to keep the Puppet communities awesome, and we need your help to keep it
44
that way. While we have specific guidelines for various tools (see links below),
55
in general, you should:
66

7-
* **Be nice**: Be courteous, respectful and polite to fellow community members. No
7+
- **Be nice**: Be courteous, respectful and polite to fellow community members. No
88
offensive comments related to gender, gender identity or expression, sexual
99
orientation, disability, physical appearance, body size, race, religion; no
1010
sexual images in public spaces, real or implied violence, intimidation,
1111
oppression, stalking, following, harassing photography or recording, sustained
1212
disruption of talks or other events, inappropriate physical contact, doxxing, or
1313
unwelcome sexual attention will be tolerated. We like nice people way better
1414
than mean ones!
15-
* **Encourage diversity and participation**: Make everyone in our community feel
15+
- **Encourage diversity and participation**: Make everyone in our community feel
1616
welcome, regardless of their background, and do everything possible to encourage
1717
participation in our community.
18-
* **Focus on constructive criticisms**: When offering suggestions, whether in online
18+
- **Focus on constructive criticisms**: When offering suggestions, whether in online
1919
discussions or as comments on a pull request, you should always use welcoming
2020
and inclusive language. Be respectful of differing viewpoints and the fact that
2121
others may not have the same experiences you do. Offer suggestions for
2222
improvement, rather than focusing on mistakes. When others critique your work or
2323
ideas, gracefully accept the criticisms and default to assuming good intentions.
24-
* **Keep it legal**: Basically, don't get us in trouble. Share only content that you
24+
- **Keep it legal**: Basically, don't get us in trouble. Share only content that you
2525
own, do not share private or sensitive information, and don't break the law.
26-
* **Stay on topic**: Keep conversation in a thread on topic, whether that's a pull
26+
- **Stay on topic**: Keep conversation in a thread on topic, whether that's a pull
2727
request or a Slack conversation or anything else. Make sure that you are posting
2828
to the correct channel and remember that nobody likes spam.
2929

@@ -34,19 +34,19 @@ do need a fair way to deal with people who do harm to our community. Extreme
3434
violations of a threatening, abusive, destructive, or illegal nature will be
3535
addressed immediately and are not subject to 3 strikes.
3636

37-
* First occurrence: We'll give you a friendly, but public, reminder that the
37+
- First occurrence: We'll give you a friendly, but public, reminder that the
3838
behavior is inappropriate according to our guidelines.
39-
* Second occurrence: We'll send you a private message with a warning that any
39+
- Second occurrence: We'll send you a private message with a warning that any
4040
additional violations will result in removal from the community.
41-
* Third occurrence: Depending on the violation, we might need to delete or ban
41+
- Third occurrence: Depending on the violation, we might need to delete or ban
4242
your account.
4343

4444
Notes:
4545

46-
* Obvious spammers are banned on first occurrence. If we don’t do this, we’ll
46+
- Obvious spammers are banned on first occurrence. If we don’t do this, we’ll
4747
have spam all over the place.
48-
* Violations are forgiven after 6 months of good behavior, and we won’t hold a grudge.
49-
* People who are committing minor formatting / style infractions will get some
48+
- Violations are forgiven after 6 months of good behavior, and we won’t hold a grudge.
49+
- People who are committing minor formatting / style infractions will get some
5050
education, rather than hammering them in the 3 strikes process.
5151

5252
Contact [email protected] to report abuse or appeal violations. This email list
@@ -67,4 +67,4 @@ Credit to [01.org](https://01.org/community/participation-guidelines) and
6767
starting point for many of these guidelines.
6868

6969
The Event Code of Conduct is based on the [example policy from the Geek Feminism wiki](http://geekfeminism.wikia.com/wiki/Conference_anti-harassment),
70-
created by the Ada Initiative and other volunteers. The [PyCon Code of Conduct](https://github.com/python/pycon-code-of-conduct) also served as inspiration.
70+
created by the Ada Initiative and other volunteers. The [PyCon Code of Conduct](https://github.com/python/pycon-code-of-conduct) also served as inspiration.

0 commit comments

Comments
 (0)