Merge pull request #56 from jonathannewman/maint/main/avoid-unexpected-selection-updates

(maint) avoid calling "onSelect" when the tab is already selected

Author: jonathannewman

addon/components/ivy-tabs-tab.js

@@ -105,6 +105,7 @@ export default class IvyTabsTabComponent extends Component {
   select() {
     const onSelect = this.args.onSelect;
     if (
+      !this.isSelected &&
       !this.isDestroying &&
       !this.isDestroyed &&
       typeof onSelect === 'function'

tests/dummy/app/controllers/dynamic-tabs.js

@@ -28,9 +28,7 @@ export default class DynamicTabsController extends Controller {
 
   @action
   updateDynamicSelection(item) {
-    if (this.selection !== item) {
-      this.selection = item;
-    }
+    this.selection = item;
   }
 
   get checkedItems() {

tests/dummy/app/controllers/query-params.js

@@ -11,8 +11,6 @@ export default class QueryParamsController extends Controller {
 
   @action
   updateQuerySelection(newValue) {
-    if (this.selection !== newValue) {
-      this.selection = newValue;
-    }
+    this.selection = newValue;
   }
 }