Merge pull request #229 from jcharaoui/top_scope_facts_cli

add --top-scope-variables cli argument, fix #228

Author: LukasAud

.rubocop_todo.yml

@@ -60,10 +60,10 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 33
 
-# Offense count: 80
+# Offense count: 81
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 108
+  Max: 111
 
 # Offense count: 26
 # Configuration parameters: AllowedMethods, AllowedPatterns.

lib/puppet-lint/optparser.rb

@@ -128,6 +128,10 @@ def self.build(args = [])
         PuppetLint.configuration.ignore_paths = paths.split(',')
       end
 
+      opts.on('--top-scope-variables VARS', 'A comma separated list of allowed top scope variables') do |vars|
+        PuppetLint.configuration.top_scope_variables = vars.split(',')
+      end
+
       PuppetLint.configuration.checks.each do |check|
         opts.on("--no-#{check}-check", "Skip the #{check} check.") do
           PuppetLint.configuration.send(:"disable_#{check}")

spec/fixtures/test/manifests/top_scope_variables.pp

@@ -0,0 +1,4 @@
+# dummy resource to test --top-scope-variables
+define test::top_scope_variables() {
+  notice($::role)
+}

spec/unit/puppet-lint/bin_spec.rb

@@ -121,6 +121,18 @@ def initialize(args)
     its(:stdout) { is_expected.to eq('') }
   end
 
+  context 'when passed top scope variables option' do
+    let(:args) do
+      [
+        '--top-scope-variables=role',
+        'spec/fixtures/test/manifests/top_scope_variables.pp',
+      ]
+    end
+
+    its(:exitstatus) { is_expected.to eq(0) }
+    its(:stdout) { is_expected.to eq('') }
+  end
+
   context 'when limited to errors only' do
     let(:args) do
       [