(CDPE-4754) Rewrite create_git_branch spec for V1 endpoint

Stubs the new V1 path with workspaceId query param. Asserts the V1
return shape: 204 maps to {'result' => 'success'}, 4xx maps the V1
error body's message to the function-result error shape, and 5xx
raises Puppet::Error.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Magisus

spec/functions/cd4pe/create_git_branch_spec.rb

@@ -3,8 +3,6 @@
 require 'webmock/rspec'
 
 describe 'cd4pe_deployments::create_git_branch' do
-  let(:ajax_op) { 'CreateGitBranch' }
-
   context 'table steaks' do
     include_context 'deployment'
 
@@ -21,61 +19,72 @@
     include_context 'deployment'
 
     let(:repo_type) { 'CONTROL_REPO' }
-    let(:git_branch) { 'development_b' }
+    let(:branch_name) { 'development_b' }
     let(:commit_sha) { 'c090ea692e67405c5572af6b2a9dc5f11c9080c0' }
-    let(:response) do
-      {
-        'result' => {
-          'success' => true,
-        },
-        'error' => nil,
-      }
+    let(:full_path) do
+      "#{api_v1_path}/deployments/#{deployment_id}:create-git-branch?workspaceId=#{deployment_domain}"
     end
 
-    it 'succeeds with parameters' do
-      stub_request(:post, ajax_url)
+    it 'returns success on 204' do
+      stub_request(:post, full_path)
         .with(
           body: {
-            op: ajax_op,
-            content: {
-              repoType: repo_type,
-              deploymentId: deployment_id,
-              branchName: git_branch,
-              commitSha: commit_sha,
-              cleanup: true,
-            },
+            repoType: repo_type,
+            branchName: branch_name,
+            commitSha: commit_sha,
+            cleanup: true,
           },
           headers: {
             'authorization' => ENV['DEPLOYMENT_TOKEN'],
           },
         )
-        .to_return(body: JSON.generate(response['result']))
+        .to_return(status: 204, body: '')
         .times(1)
 
-      is_expected.to run.with_params(repo_type, git_branch, commit_sha).and_return(response)
+      is_expected
+        .to run
+        .with_params(repo_type, branch_name, commit_sha)
+        .and_return({'result' => 'success', 'error' => nil})
     end
 
-    it 'fails with non-200 response code' do
-      stub_request(:post, ajax_url)
+    it 'returns error result on 4xx with a V1 error body' do
+      v1_error_body = {
+        'message' => 'Some error message',
+        'traceId' => 'abc',
+        'uriPath' => full_path,
+      }
+      stub_request(:post, full_path)
         .with(
           body: {
-            op: ajax_op,
-            content: {
-              repoType: repo_type,
-              deploymentId: deployment_id,
-              branchName: git_branch,
-              commitSha: commit_sha,
-              cleanup: true,
-            },
+            repoType: repo_type,
+            branchName: branch_name,
+            commitSha: commit_sha,
+            cleanup: true,
           },
           headers: {
             'authorization' => ENV['DEPLOYMENT_TOKEN'],
           },
         )
-        .to_return(body: JSON.generate(error_response), status: 404)
+        .to_return(status: 400, body: JSON.generate(v1_error_body))
+        .times(1)
+
+      is_expected
+        .to run
+        .with_params(repo_type, branch_name, commit_sha)
+        .and_return(
+          {'result' => nil, 'error' => {'message' => 'Some error message', 'code' => '400'}},
+        )
+    end
+
+    it 'raises on 5xx' do
+      stub_request(:post, full_path)
+        .to_return(status: 500, body: 'boom')
         .times(1)
 
-      is_expected.to run.with_params(repo_type, git_branch, commit_sha).and_return(error_response)
+      is_expected
+        .to run
+        .with_params(repo_type, branch_name, commit_sha)
+        .and_raise_error(Puppet::Error)
     end
   end
 end