(MODULES-11802) Downcase charset/collate before normalising

Charset and collation names are case-insensitive in MySQL/MariaDB and the
server always reports them lowercased. Downcase in normalise_utf8 so a user
who supplies an uppercase value (e.g. `UTF8`) also compares in sync with the
lowercase server value, rather than drifting on every run. Adds unit
coverage for uppercase charset/collate input.

Addresses review feedback on PR #1712.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: skyamgarp

lib/puppet/type/mysql_database.rb

@@ -17,9 +17,11 @@
   # `utf8` is a deprecated alias for `utf8mb3` in both MySQL and MariaDB. Newer
   # servers (e.g. MariaDB 11 on RHEL 10) report the canonical `utf8mb3` name back,
   # while users typically request `utf8`. Treat the two spellings as equivalent so
-  # the resource stays idempotent regardless of which the server reports.
+  # the resource stays idempotent regardless of which the server reports. Charset
+  # and collation names are case-insensitive and the server reports them
+  # lowercased, so downcase first to also match user input such as `UTF8`.
   def self.normalise_utf8(value)
-    value.to_s.sub(%r{^utf8mb3}, 'utf8')
+    value.to_s.downcase.sub(%r{^utf8mb3}, 'utf8')
   end
 
   newproperty(:charset) do

spec/unit/puppet/type/mysql_database_spec.rb

@@ -51,5 +51,15 @@
       resource = Puppet::Type.type(:mysql_database).new(name: 'test', collate: 'utf8_general_ci')
       expect(resource.property(:collate).insync?('latin1_swedish_ci')).to be false
     end
+
+    it 'treats uppercase charset input as in sync with the lowercase server value' do
+      resource = Puppet::Type.type(:mysql_database).new(name: 'test', charset: 'UTF8')
+      expect(resource.property(:charset).insync?('utf8mb3')).to be true
+    end
+
+    it 'treats uppercase collate input as in sync with the lowercase server value' do
+      resource = Puppet::Type.type(:mysql_database).new(name: 'test', collate: 'UTF8_GENERAL_CI')
+      expect(resource.property(:collate).insync?('utf8mb3_general_ci')).to be true
+    end
   end
 end