Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

Disconnect function in Socket API Call in Push Dev Docs/Integrating Push Chats  #8

Open
@adityakode

Description

@adityakode

Hello,
In https://github.com/ethereum-push-notification-service/push-dev-docs/blob/main/developer-guides/integrating-push-chat.md
In the socket API Call, To connect we use pushSDKSocket.connect()
while for disconnect, the same function is given pushSDKSocket.connect().

image
This is a minor issue and I would love to fix it.
I think the correct function would be pushSDKSocket.disconnect()
Would love to be assigned this issue so I can fix it as soon as possible and help reduce confusion for developers who build on push protocol.
Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions