feat: pushchain/evm v0.2.0 to 0.3.2 upgrade changes (#223)

* 0.3.2 evm upgrade changes

* fix: (evm 0.3.2) wrap CallEVMWithData in CacheContext to prevent gas-meter overflow on reverts

* fix: go.mod and go.sum for evm-0.3.2 update

* upgrade handler for 0.3.2 evm upgrade added

* fix: handle EVM_CHAIN_ID when chain id needs to be replaced.

* refactor: merge upgrade handlers

---------

Co-authored-by: Mohammed S <shoaibmohammed92@gmail.com>
Co-authored-by: Nilesh Gupta <guptanilesh2312@gmail.com>

Author: 3 people

.github/workflows/release.yml

@@ -123,6 +123,7 @@ jobs:
       - name: Patch chain ID for production
         run: |
           sed -i 's/"localchain_9000-1"/"push_42101-1"/' app/app.go
+          sed -i 's/EVMChainID = uint64(9000)/EVMChainID = uint64(42101)/' app/app.go
           grep -n "ChainID" app/app.go
 
       - name: Build Linux binary
@@ -247,6 +248,7 @@ jobs:
       - name: Patch chain ID for production
         run: |
           sed -i 's/"localchain_9000-1"/"push_42101-1"/' app/app.go
+          sed -i 's/EVMChainID = uint64(9000)/EVMChainID = uint64(42101)/' app/app.go
           grep -n "ChainID" app/app.go
 
       - name: Build Linux ARM64 binary
@@ -390,6 +392,7 @@ jobs:
       - name: Patch chain ID for production
         run: |
           sed -i '' 's/"localchain_9000-1"/"push_42101-1"/' app/app.go
+          sed -i '' 's/EVMChainID = uint64(9000)/EVMChainID = uint64(42101)/' app/app.go
           grep -n "ChainID" app/app.go
 
       - name: Build Mac Binary (ARM64 only - native build)

app/ante/ante_evm.go

@@ -1,15 +1,36 @@
 package ante
 
 import (
+	"time"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	evmante "github.com/cosmos/evm/ante/evm"
+	anteinterfaces "github.com/cosmos/evm/ante/interfaces"
 )
 
+// evmAccountKeeperWrapper adapts push-chain's AccountKeeper to satisfy the
+// cosmos/evm interfaces.AccountKeeper, which requires unordered-tx methods not
+// present in cosmos-sdk v0.50.x. Stubs return safe no-op values because
+// unordered transactions are not enabled on this chain.
+type evmAccountKeeperWrapper struct {
+	AccountKeeper
+}
+
+var _ anteinterfaces.AccountKeeper = evmAccountKeeperWrapper{}
+
+func (w evmAccountKeeperWrapper) UnorderedTransactionsEnabled() bool { return false }
+
+func (w evmAccountKeeperWrapper) RemoveExpiredUnorderedNonces(_ sdk.Context) error { return nil }
+
+func (w evmAccountKeeperWrapper) TryAddUnorderedNonce(_ sdk.Context, _ []byte, _ time.Time) error {
+	return nil
+}
+
 // newMonoEVMAnteHandler creates the sdk.AnteHandler implementation for the EVM transactions.
 func newMonoEVMAnteHandler(options HandlerOptions) sdk.AnteHandler {
 	return sdk.ChainAnteDecorators(
 		evmante.NewEVMMonoDecorator(
-			options.AccountKeeper,
+			evmAccountKeeperWrapper{options.AccountKeeper},
 			options.FeeMarketKeeper,
 			options.EvmKeeper,
 			options.MaxTxGasWanted,

app/app.go

@@ -9,6 +9,7 @@ import (
 	"path/filepath"
 	"sort"
 	"sync"
+	"time"
 
 	autocliv1 "cosmossdk.io/api/cosmos/autocli/v1"
 	reflectionv1 "cosmossdk.io/api/cosmos/reflection/v1"
@@ -185,7 +186,8 @@ const (
 	NodeDir      = ".pchain"
 	Bech32Prefix = "push"
 
-	ChainID = "localchain_9000-1"
+	ChainID    = "localchain_9000-1"
+	EVMChainID = uint64(9000)
 )
 
 var (
@@ -198,6 +200,20 @@ var (
 	}
 )
 
+// authKeeperEVMWrapper adapts cosmos-sdk v0.50.x AccountKeeper to satisfy the
+// cosmos/evm AccountKeeper interfaces, which require unordered-tx methods not
+// present in sdk v0.50. Stubs are safe no-ops because this chain does not
+// enable unordered transactions.
+type authKeeperEVMWrapper struct {
+	authkeeper.AccountKeeper
+}
+
+func (w authKeeperEVMWrapper) UnorderedTransactionsEnabled() bool { return false }
+func (w authKeeperEVMWrapper) RemoveExpiredUnorderedNonces(_ sdk.Context) error { return nil }
+func (w authKeeperEVMWrapper) TryAddUnorderedNonce(_ sdk.Context, _ []byte, _ time.Time) error {
+	return nil
+}
+
 func init() {
 	// manually update the power reduction based on the base denom unit (10^18 [evm] or 10^6 [cosmos])
 	sdk.DefaultPowerReduction = math.NewIntFromBigInt(new(big.Int).Exp(big.NewInt(10), big.NewInt(BaseDenomUnit), nil))
@@ -345,7 +361,7 @@ func NewChainApp(
 
 	// TODO: verify
 
-	encodingConfig := cosmosevmencoding.MakeConfig()
+	encodingConfig := cosmosevmencoding.MakeConfig(EVMChainID)
 	interfaceRegistry := encodingConfig.InterfaceRegistry
 	appCodec := encodingConfig.Codec
 	legacyAmino := encodingConfig.Amino
@@ -686,11 +702,13 @@ func NewChainApp(
 		appCodec,
 		keys[evmtypes.StoreKey],
 		tkeys[evmtypes.TransientKey],
+		keys,
 		authtypes.NewModuleAddress(govtypes.ModuleName),
-		app.AccountKeeper,
+		authKeeperEVMWrapper{app.AccountKeeper},
 		app.BankKeeper,
 		app.StakingKeeper,
 		app.FeeMarketKeeper,
+		app.ConsensusParamsKeeper,
 		&app.Erc20Keeper,
 		tracer,
 	)
@@ -776,6 +794,7 @@ func NewChainApp(
 		app.GovKeeper,
 		app.SlashingKeeper,
 		app.EvidenceKeeper,
+		appCodec,
 	)
 
 	// Add the usigverifier precompile for Ed25519 verification (old address: 0xCA)
@@ -1027,7 +1046,7 @@ func NewChainApp(
 		packetforward.NewAppModule(app.PacketForwardKeeper, app.GetSubspace(packetforwardtypes.ModuleName)),
 		wasmlc.NewAppModule(app.WasmClientKeeper),
 		ratelimit.NewAppModule(appCodec, app.RatelimitKeeper),
-		vm.NewAppModule(app.EVMKeeper, app.AccountKeeper),
+		vm.NewAppModule(app.EVMKeeper, authKeeperEVMWrapper{app.AccountKeeper}, app.AccountKeeper.AddressCodec()),
 		feemarket.NewAppModule(app.FeeMarketKeeper),
 		erc20.NewAppModule(app.Erc20Keeper, app.AccountKeeper),
 		uexecutor.NewAppModule(appCodec, app.UexecutorKeeper, app.EVMKeeper, app.FeeMarketKeeper, app.BankKeeper, app.AccountKeeper, app.UregistryKeeper, app.UvalidatorKeeper),
@@ -1437,7 +1456,7 @@ func (a *ChainApp) DefaultGenesis() map[string]json.RawMessage {
 	// which is the base denomination of the chain (i.e. the WTOKEN contract)
 	erc20GenState := erc20types.DefaultGenesisState()
 	erc20GenState.TokenPairs = ExampleTokenPairs
-	erc20GenState.Params.NativePrecompiles = append(erc20GenState.Params.NativePrecompiles, WTokenContractMainnet)
+	erc20GenState.NativePrecompiles = append(erc20GenState.NativePrecompiles, WTokenContractMainnet)
 	genesis[erc20types.ModuleName] = a.appCodec.MustMarshalJSON(erc20GenState)
 
 	return genesis
@@ -1560,7 +1579,7 @@ func BlockedAddresses() map[string]bool {
 	}
 
 	for _, precompile := range blockedPrecompilesHex {
-		blockedAddrs[cosmosevmutils.EthHexToCosmosAddr(precompile).String()] = true
+		blockedAddrs[cosmosevmutils.Bech32StringFromHexAddress(precompile)] = true
 	}
 
 	return blockedAddrs

app/config.go

@@ -59,7 +59,7 @@ func EVMAppOptions(chainID string) error {
 		return err
 	}
 
-	ethCfg := evmtypes.DefaultChainConfig(chainID)
+	ethCfg := evmtypes.DefaultChainConfig(EVMChainID)
 
 	err := evmtypes.NewEVMConfigurator().
 		WithChainConfig(ethCfg).

app/precompiles.go

@@ -5,6 +5,7 @@ import (
 	"maps"
 
 	evidencekeeper "cosmossdk.io/x/evidence/keeper"
+	"github.com/cosmos/cosmos-sdk/codec"
 	distributionkeeper "github.com/cosmos/cosmos-sdk/x/distribution/keeper"
 	govkeeper "github.com/cosmos/cosmos-sdk/x/gov/keeper"
 	slashingkeeper "github.com/cosmos/cosmos-sdk/x/slashing/keeper"
@@ -43,6 +44,7 @@ func NewAvailableStaticPrecompiles(
 	govKeeper govkeeper.Keeper,
 	slashingKeeper slashingkeeper.Keeper,
 	evidenceKeeper evidencekeeper.Keeper,
+	appCodec codec.Codec,
 ) map[common.Address]vm.PrecompiledContract {
 	// Clone the mapping from the latest EVM fork.
 	precompiles := maps.Clone(vm.PrecompiledContractsBerlin)
@@ -55,13 +57,14 @@ func NewAvailableStaticPrecompiles(
 		panic(fmt.Errorf("failed to instantiate bech32 precompile: %w", err))
 	}
 
-	stakingPrecompile, err := stakingprecompile.NewPrecompile(stakingKeeper)
+	stakingPrecompile, err := stakingprecompile.NewPrecompile(stakingKeeper, bankKeeper)
 	if err != nil {
 		panic(fmt.Errorf("failed to instantiate staking precompile: %w", err))
 	}
 
 	distributionPrecompile, err := distprecompile.NewPrecompile(
 		distributionKeeper,
+		bankKeeper,
 		stakingKeeper,
 		evmKeeper,
 	)
@@ -71,6 +74,7 @@ func NewAvailableStaticPrecompiles(
 
 	ibcTransferPrecompile, err := ics20precompile.NewPrecompile(
 		stakingKeeper,
+		bankKeeper,
 		transferKeeper,
 		channelKeeper,
 		evmKeeper,
@@ -84,17 +88,17 @@ func NewAvailableStaticPrecompiles(
 		panic(fmt.Errorf("failed to instantiate bank precompile: %w", err))
 	}
 
-	govPrecompile, err := govprecompile.NewPrecompile(govKeeper)
+	govPrecompile, err := govprecompile.NewPrecompile(govKeeper, bankKeeper, appCodec)
 	if err != nil {
 		panic(fmt.Errorf("failed to instantiate gov precompile: %w", err))
 	}
 
-	slashingPrecompile, err := slashingprecompile.NewPrecompile(slashingKeeper)
+	slashingPrecompile, err := slashingprecompile.NewPrecompile(slashingKeeper, bankKeeper)
 	if err != nil {
 		panic(fmt.Errorf("failed to instantiate slashing precompile: %w", err))
 	}
 
-	evidencePrecompile, err := evidenceprecompile.NewPrecompile(evidenceKeeper)
+	evidencePrecompile, err := evidenceprecompile.NewPrecompile(evidenceKeeper, bankKeeper)
 	if err != nil {
 		panic(fmt.Errorf("failed to instantiate evidence precompile: %w", err))
 	}

app/upgrades/contract-audit-changes/upgrade.go

@@ -13,12 +13,23 @@ import (
 	"github.com/pushchain/push-chain-node/app/upgrades"
 )
 
+// Upgrade for chain contract audit changes + evm version bump to 0.3.2
 // UpgradeName matches the chain-side change set that adapts the chain's
 // UniversalCore ABI + gas-fee read path to the post-audit smart-contract
 // No module ConsensusVersion is bumped for this upgrade — none of the chain
 // changes touch module storage schemas, so RunMigrations is a no-op for the
 // version map; this handler exists primarily as a coordination point so all
 // validators flip to the new ABI / gas-fee read at the same height.
+
+// Key changes in this library bump:
+//   - AccountKeeper now requires unordered-tx methods (satisfied via authKeeperEVMWrapper stub)
+//   - EVMKeeper constructor takes additional params: store keys map, ConsensusParamsKeeper
+//   - go-ethereum bumped to v1.15.11-cosmos-0; statedb.Account.Balance is now uint256.Int (not big.Int)
+//   - erc20 module: NativePrecompiles moved from Params to a top-level genesis field
+//   - Precompile constructors now require bankKeeper; gov precompile also requires appCodec
+//   - vm.NewAppModule signature updated to accept AddressCodec
+//
+// RunMigrations handles the erc20 state migration automatically (consensus version bump).
 const UpgradeName = "contract-audit-changes"
 
 func NewUpgrade() upgrades.Upgrade {
@@ -41,10 +52,12 @@ func CreateUpgradeHandler(
 		sdkCtx := sdk.UnwrapSDKContext(ctx)
 		logger := sdkCtx.Logger().With("upgrade", UpgradeName)
 		logger.Info("Starting upgrade handler")
+		logger.Info("cosmos/evm v0.2.x → v0.3.2: erc20 NativePrecompiles field migration, go-ethereum v1.15.11-cosmos-0")
+		logger.Info("UniversalCore audit: ABI gasLimitUsed output, setGasPrice removal, gas_fee.go reads results[5]")
 
-		// RunMigrations is a no-op for this upgrade (no module ConsensusVersion
-		// bumped) but we still call it so the version map is materialised
-		// correctly for any modules whose code may have changed underneath.
+		// erc20 module's ConsensusVersion bump (from EVM 0.3.2) drives the
+		// only on-chain state migration this upgrade requires; RunMigrations
+		// handles it. The chain's own modules don't bump versions here.
 		versionMap, err := mm.RunMigrations(ctx, configurator, fromVM)
 		if err != nil {
 			return nil, fmt.Errorf("RunMigrations: %w", err)