Skip to content

Commit 9a62b22

Browse files
committed
Resolve warnings
1 parent ac6bb0b commit 9a62b22

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

CHANGELOG.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Changelog
2-
3-
## 2.3.0
1+
# Changelog
2+
3+
## 2.3.0-beta
44
* [Added] Introduce user features
55

66
## 2.2.1

PusherClient/UserFacade.cs

+6-4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ await _CriticalSection(() => {
6767
return;
6868
}
6969

70+
#pragma warning disable 4014
71+
// We don't want to wait for Signin to complete.
7072
_Signin();
7173
}
7274

@@ -150,7 +152,7 @@ await _CriticalSection(() => {
150152
}
151153

152154
// The current code doesn't prevent SinginProcess from being called twice in parallel.
153-
SinginProcess();
155+
await SinginProcess();
154156
}
155157

156158

@@ -178,7 +180,7 @@ internal void OnPusherEvent(string eventName, PusherEvent pusherEvent) {
178180
_watchlistFacade.OnPusherEvent(eventName, pusherEvent);
179181
}
180182

181-
private void _OnSigninSuccess(PusherEvent pusherEvent) {
183+
private async void _OnSigninSuccess(PusherEvent pusherEvent) {
182184
// Try to parse event
183185
try {
184186
String data = pusherEvent.Data;
@@ -201,7 +203,7 @@ private void _OnSigninSuccess(PusherEvent pusherEvent) {
201203
user = ParseUser(userData);
202204
} catch (Exception error) {
203205
Console.WriteLine($"{Environment.NewLine} error parsing user {error}");
204-
this._Cleanup(error);
206+
await this._Cleanup(error);
205207
return;
206208
}
207209

@@ -244,7 +246,7 @@ private async Task SinginProcess() {
244246
string message = CreateSigninMessage(authResponse);
245247
await connection.SendAsync(message).ConfigureAwait(false);
246248
} catch (Exception error) {
247-
this._Cleanup(error);
249+
await this._Cleanup(error);
248250
return;
249251
}
250252
}

Root.Build.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<PackageDescription>The .NET library for interacting with the Pusher WebSocket API. Register at http://pusher.com</PackageDescription>
1313
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1414
<PackageIcon>icon-128.png</PackageIcon>
15-
<Version>2.3.0</Version>
15+
<Version>2.3.0-beta</Version>
1616
<AssemblyVersion>2.3.0.0</AssemblyVersion>
1717
<FileVersion>2.3.0.0</FileVersion>
1818
</PropertyGroup>

0 commit comments

Comments
 (0)