Skip to content

Commit 7ceb198

Browse files
authored
Merge pull request #50 from bacht-fidi/master
Fix: remove legacy API versions
2 parents db70e03 + 9169711 commit 7ceb198

File tree

6 files changed

+13
-16
lines changed

6 files changed

+13
-16
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ A [cert-manager][2] ACME DNS01 solver webhook for [DNSimple][1].
55

66
## Pre-requisites
77

8-
- [cert-manager][2] >= 0.13 (The Helm chart uses the new API versions)
8+
- [cert-manager][2] >= 1.0.0 (The Helm chart uses the new API versions)
99
- Kubernetes >= 1.17.x
1010
- Helm 3 (otherwise adjust the example below accordingly)
1111

charts/cert-manager-webhook-dnsimple/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v1
2-
appVersion: "v0.1.4"
2+
appVersion: "v0.1.5"
33
description: cert-manager webhook solver for ACME DNS01 challenge via DNSimple
44
name: cert-manager-webhook-dnsimple
5-
version: 0.1.4
5+
version: 0.1.5
66
home: https://github.com/puzzle/cert-manager-webhook-dnsimple
77
sources:
88
- https://github.com/puzzle/cert-manager-webhook-dnsimple

charts/cert-manager-webhook-dnsimple/templates/apiservice.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
{{- $APIRegistrationAPIVersion := ternary "apiregistration.k8s.io/v1" "apiregistration.k8s.io/v1beta1" (.Capabilities.APIVersions.Has "apiregistration.k8s.io/v1") -}}
2-
apiVersion: {{ $APIRegistrationAPIVersion }}
1+
apiVersion: apiregistration.k8s.io/v1
32
kind: APIService
43
metadata:
54
name: v1alpha1.{{ include "dnsimple-webhook.api-group" . }}

charts/cert-manager-webhook-dnsimple/templates/pki.yaml

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
{{- $CertManagerAPIVersion := ternary "cert-manager.io/v1" "cert-manager.io/v1alpha2" (.Capabilities.APIVersions.Has "cert-manager.io/v1") -}}
21
---
32
# Create a selfsigned Issuer, in order to create a root CA certificate for
43
# signing webhook serving certificates
5-
apiVersion: {{ $CertManagerAPIVersion }}
4+
apiVersion: cert-manager.io/v1
65
kind: Issuer
76
metadata:
87
name: {{ include "dnsimple-webhook.selfSignedIssuer" . }}
@@ -18,7 +17,7 @@ spec:
1817
---
1918

2019
# Generate a CA Certificate used to sign certificates for the webhook
21-
apiVersion: {{ $CertManagerAPIVersion }}
20+
apiVersion: cert-manager.io/v1
2221
kind: Certificate
2322
metadata:
2423
name: {{ include "dnsimple-webhook.rootCACertificate" . }}
@@ -39,7 +38,7 @@ spec:
3938
---
4039

4140
# Create an Issuer that uses the above generated CA certificate to issue certs
42-
apiVersion: {{ $CertManagerAPIVersion }}
41+
apiVersion: cert-manager.io/v1
4342
kind: Issuer
4443
metadata:
4544
name: {{ include "dnsimple-webhook.rootCAIssuer" . }}
@@ -56,7 +55,7 @@ spec:
5655
---
5756

5857
# Finally, generate a serving certificate for the webhook to use
59-
apiVersion: {{ $CertManagerAPIVersion }}
58+
apiVersion: cert-manager.io/v1
6059
kind: Certificate
6160
metadata:
6261
name: {{ include "dnsimple-webhook.servingCertificate" . }}

charts/cert-manager-webhook-dnsimple/templates/rbac.yaml

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{{- $RBACAPIVersion := ternary "rbac.authorization.k8s.io/v1" "rbac.authorization.k8s.io/v1beta1" (.Capabilities.APIVersions.Has "rbac.authorization.k8s.io/v1") -}}
21
apiVersion: v1
32
kind: ServiceAccount
43
metadata:
@@ -12,7 +11,7 @@ metadata:
1211
# Grant the webhook permission to read the ConfigMap containing the Kubernetes
1312
# apiserver's requestheader-ca-certificate.
1413
# This ConfigMap is automatically created by the Kubernetes apiserver.
15-
apiVersion: {{ $RBACAPIVersion }}
14+
apiVersion: rbac.authorization.k8s.io/v1
1615
kind: RoleBinding
1716
metadata:
1817
name: {{ include "dnsimple-webhook.fullname" . }}:webhook-authentication-reader
@@ -34,7 +33,7 @@ subjects:
3433
---
3534
# apiserver gets the auth-delegator role to delegate auth decisions to
3635
# the core apiserver
37-
apiVersion: {{ $RBACAPIVersion }}
36+
apiVersion: rbac.authorization.k8s.io/v1
3837
kind: ClusterRoleBinding
3938
metadata:
4039
name: {{ include "dnsimple-webhook.fullname" . }}:auth-delegator
@@ -54,7 +53,7 @@ subjects:
5453
namespace: {{ .Release.Namespace }}
5554
---
5655
# Grant cert-manager permission to validate using our apiserver
57-
apiVersion: {{ $RBACAPIVersion }}
56+
apiVersion: rbac.authorization.k8s.io/v1
5857
kind: ClusterRole
5958
metadata:
6059
name: {{ include "dnsimple-webhook.fullname" . }}:domain-solver

charts/cert-manager-webhook-dnsimple/values.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ clusterIssuer:
2020
enabled: false
2121
image:
2222
repository: ghcr.io/puzzle/cert-manager-webhook-dnsimple
23-
tag: v0.1.4
23+
tag: v0.1.5
2424
pullPolicy: IfNotPresent
2525
# pullSecret: "gcr"
2626
nameOverride: ""
@@ -43,4 +43,4 @@ resources: {}
4343

4444
nodeSelector: {}
4545
tolerations: []
46-
affinity: {}
46+
affinity: {}

0 commit comments

Comments
 (0)