write tests

Author: kcinay055679

Diff for: frontend/app/components/encryptable/form.js

@@ -49,7 +49,7 @@ export default class Form extends BaseFormComponent {
     if (!this.record.isFullyLoaded)
       this.store.findRecord("encryptable-credential", this.record.id);
 
-    this.setRandomPassword(this.withSymbols, this.passwordLength);
+    this.setRandomPassword();
   }
 
   presetTeamAndFolder() {
@@ -80,7 +80,11 @@ export default class Form extends BaseFormComponent {
   }
 
   @action
-  setRandomPassword(withSymbols, passwordLength) {
+  setRandomPassword(
+    withSymbols = this.withSymbols,
+    passwordLength = this.passwordLength
+  ) {
+    console.log("tes");
     let pass = "";
     const array = new Uint32Array(1);
     const PASSWORD_CHARS =

Diff for: frontend/app/templates/components/encryptable/form.hbs

@@ -75,6 +75,7 @@
                   <label>
                     Symbols
                     <Input
+                      id="withSymbols"
                       @type="checkbox"
                       @checked={{this.withSymbols}} {{on "change" (fn this.setRandomPassword invertedWithSymbols passwordLength)}}></Input>
                   </label>

Diff for: frontend/tests/integration/components/encryptable/form-test.js

@@ -1,11 +1,19 @@
 import { module, test } from "qunit";
 import { setupRenderingTest } from "ember-qunit";
-import { render } from "@ember/test-helpers";
+import {
+  click,
+  render,
+  triggerKeyEvent,
+  pauseTest,
+  triggerEvent,
+  find
+} from "@ember/test-helpers";
 import { hbs } from "ember-cli-htmlbars";
 import Service from "@ember/service";
 import { clickTrigger } from "ember-power-select/test-support/helpers";
 import { selectChoose } from "ember-power-select/test-support";
 import { setLocale } from "ember-intl/test-support";
+import { scrollTo } from "@ember/test-helpers";
 
 const navServiceStub = Service.extend({
   /* eslint-disable ember/avoid-leaking-state-in-ember-objects */
@@ -295,4 +303,58 @@ module("Integration | Component | encryptable/form", function (hooks) {
     assert.ok(this.element.textContent.trim().includes("supporting"));
     assert.ok(this.element.textContent.trim().includes("bbt"));
   });
+
+  test("generates a 14 digit password per default", async function (assert) {
+    await render(hbs`<Encryptable::Form />`);
+
+    assert.equal(
+      this.element.querySelector("input[name='cleartextPassword']").value
+        .length,
+      14
+    );
+  });
+
+  test("Symbols are enabled per default", async function (assert) {
+    await render(hbs`<Encryptable::Form />`);
+    assert.equal(this.element.querySelector("input#withSymbols").checked, true);
+  });
+
+  test("Password does not contain symbols after unchecking checkbox", async function (assert) {
+    await render(hbs`<Encryptable::Form />`);
+    await click("input#withSymbols");
+    assert.equal(
+      this.element.querySelector("input[name='cleartextPassword']").value
+        .length,
+      14
+    );
+
+    assert.equal(
+      this.element.querySelector("input#withSymbols").checked,
+      false
+    );
+    assert.notOk(
+      this.element.querySelector("input#withSymbols").value.match(/[^\w\s]/)
+    );
+  });
+
+  //Last test to fix
+  //The function in called correctly but the value passwordLength isnt updated
+  test("Password with the right length should be generated", async function (assert) {
+    await render(hbs`<Encryptable::Form />`);
+    const slider = this.element.querySelector("input#formControlRange");
+    slider.value = 17;
+    await triggerEvent(slider, "change");
+    await triggerEvent(slider, "input");
+    await pauseTest();
+    console.log(slider.value);
+    assert.equal(
+      this.element.querySelector("input[name='cleartextPassword']").value
+        .length,
+      17
+    );
+    await click("input#withSymbols");
+    assert.notOk(
+      this.element.querySelector("input#withSymbols").value.match(/[^\w\s]/)
+    );
+  });
 });