Skip to content

Commit 2dde360

Browse files
lkleisalkleisa
committed
Adjust e2e tests
1 parent 2c11174 commit 2dde360

File tree

2 files changed

+42
-41
lines changed

2 files changed

+42
-41
lines changed

‎frontend/cypress/e2e/objective-alignment.cy.ts

+41-41
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,9 @@ describe('OKR Objective Alignment e2e tests', () => {
1010
cy.getByTestId('add-objective').first().click();
1111

1212
cy.getByTestId('title').first().clear().type('Objective with new alignment');
13-
cy.get('select#alignment option:selected').should('contain.text', 'Bitte wählen');
14-
cy.get('select#alignment')
15-
.contains('K - Steigern der URS um 25%')
16-
.then(($option) => {
17-
const optionValue = $option.attr('value');
18-
cy.get('select#alignment').select(optionValue!);
19-
});
13+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
14+
cy.realPress('ArrowDown');
15+
cy.realPress('Enter');
2016

2117
cy.getByTestId('safe').click();
2218

@@ -31,20 +27,18 @@ describe('OKR Objective Alignment e2e tests', () => {
3127
.contains('Objective bearbeiten')
3228
.click();
3329

34-
cy.get('select#alignment option:selected').should('contain.text', 'K - Steigern der URS um 25%');
30+
cy.getByTestId('alignmentInput')
31+
.first()
32+
.should('have.value', 'O - Als BBT wollen wir den Arbeitsalltag der Members von Puzzle ITC erleichtern.');
3533
});
3634

3735
it(`Update alignment of Objective`, () => {
3836
cy.getByTestId('add-objective').first().click();
3937

4038
cy.getByTestId('title').first().clear().type('We change alignment of this Objective');
41-
cy.get('select#alignment option:selected').should('contain.text', 'Bitte wählen');
42-
cy.get('select#alignment')
43-
.contains('K - Steigern der URS um 25%')
44-
.then(($option) => {
45-
const optionValue = $option.attr('value');
46-
cy.get('select#alignment').select(optionValue!);
47-
});
39+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
40+
cy.realPress('ArrowDown');
41+
cy.realPress('Enter');
4842
cy.getByTestId('safe').click();
4943

5044
cy.contains('We change alignment of this Objective');
@@ -58,12 +52,11 @@ describe('OKR Objective Alignment e2e tests', () => {
5852
.contains('Objective bearbeiten')
5953
.click();
6054

61-
cy.get('select#alignment')
62-
.contains('K - Antwortzeit für Supportanfragen um 33% verkürzen.')
63-
.then(($option) => {
64-
const optionValue = $option.attr('value');
65-
cy.get('select#alignment').select(optionValue!);
66-
});
55+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
56+
cy.realPress('Delete');
57+
cy.realPress('ArrowDown');
58+
cy.realPress('ArrowDown');
59+
cy.realPress('Enter');
6760
cy.getByTestId('safe').click();
6861

6962
cy.getByTestId('objective')
@@ -76,23 +69,18 @@ describe('OKR Objective Alignment e2e tests', () => {
7669
.contains('Objective bearbeiten')
7770
.click();
7871

79-
cy.get('select#alignment option:selected').should(
80-
'contain.text',
81-
'K - Antwortzeit für Supportanfragen um 33% verkürzen.',
82-
);
72+
cy.getByTestId('alignmentInput')
73+
.first()
74+
.should('have.value', 'KR - Das BBT hilft den Membern 20% mehr beim Töggelen');
8375
});
8476

8577
it(`Delete alignment of Objective`, () => {
8678
cy.getByTestId('add-objective').first().click();
8779

8880
cy.getByTestId('title').first().clear().type('We delete the alignment');
89-
cy.get('select#alignment option:selected').should('contain.text', 'Bitte wählen');
90-
cy.get('select#alignment')
91-
.contains('K - Steigern der URS um 25%')
92-
.then(($option) => {
93-
const optionValue = $option.attr('value');
94-
cy.get('select#alignment').select(optionValue!);
95-
});
81+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
82+
cy.realPress('ArrowDown');
83+
cy.realPress('Enter');
9684
cy.getByTestId('safe').click();
9785

9886
cy.contains('We delete the alignment');
@@ -106,7 +94,9 @@ describe('OKR Objective Alignment e2e tests', () => {
10694
.contains('Objective bearbeiten')
10795
.click();
10896

109-
cy.get('select#alignment').select('Kein Alignment');
97+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
98+
cy.realPress('Delete');
99+
cy.tabForward();
110100
cy.getByTestId('safe').click();
111101

112102
cy.getByTestId('objective')
@@ -119,28 +109,36 @@ describe('OKR Objective Alignment e2e tests', () => {
119109
.contains('Objective bearbeiten')
120110
.click();
121111

122-
cy.get('select#alignment option:selected').should('contain.text', 'Bitte wählen');
112+
cy.getByTestId('alignmentInput').first().should('have.value', 'Bezug wählen');
123113
});
124114

125-
it(`Alignment Possibilites change when quarter change`, () => {
115+
it(`Alignment Possibilities change when quarter change`, () => {
126116
cy.visit('/?quarter=1');
127117

118+
cy.get('mat-chip:visible:contains("Alle")').click();
119+
cy.get('mat-chip:visible:contains("Alle")').click();
120+
cy.get('mat-chip:visible:contains("/BBT")').click();
121+
128122
cy.getByTestId('add-objective').first().click();
129123
cy.getByTestId('title').first().clear().type('We can link later on this');
130124
cy.getByTestId('safe').click();
131125

126+
cy.get('mat-chip:visible:contains("Alle")').click();
127+
132128
cy.getByTestId('add-objective').first().click();
133129
cy.getByTestId('title').first().clear().type('There is my other alignment');
134-
cy.get('select#alignment option:selected').should('contain.text', 'Bitte wählen');
135-
136-
cy.get('select#alignment').select(1);
130+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
131+
cy.realPress('ArrowDown');
132+
cy.realPress('Enter');
137133

138134
cy.get('select#alignment option:selected').then(($select) => {
139135
const selectValue = $select.text();
140-
cy.getByTestId('quarterSelect').select('GJ 23/24-Q1');
136+
cy.getByTestId('quarterSelect').select('GJ 22/23-Q3');
141137
cy.getByTestId('title').first().clear().type('There is our other alignment');
142138

143-
cy.get('select#alignment').select(1);
139+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
140+
cy.realPress('ArrowDown');
141+
cy.realPress('Enter');
144142

145143
cy.get('select#alignment option:selected').should('not.contain.text', selectValue);
146144
cy.getByTestId('cancel').click();
@@ -152,7 +150,9 @@ describe('OKR Objective Alignment e2e tests', () => {
152150

153151
cy.get('select#quarter').select('GJ 22/23-Q4');
154152
cy.getByTestId('title').first().clear().type('A new title');
155-
cy.get('select#alignment').select(1);
153+
cy.tabForwardUntil('[data-testId="alignmentInput"]');
154+
cy.realPress('ArrowDown');
155+
cy.realPress('Enter');
156156

157157
cy.get('select#alignment option:selected').should('contain.text', selectValue);
158158
});

‎frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
(this.filteredOptions$ | async)?.length == 0 ? 'Kein Alignment vorhanden' : 'Bezug wählen'
7979
}}"
8080
[matAutocomplete]="auto"
81+
[attr.data-testId]="'alignmentInput'"
8182
(input)="filter()"
8283
(focus)="filter(); input.select()"
8384
(focusout)="scrollLeft()"

0 commit comments

Comments
 (0)