fix(frontend): Fix updating of commitValue when creating new key-results #1570

ManuelMoeri · ManuelMoeri · commit 91cedcbba460 · 2025-08-15T11:39:27.000+02:00
diff --git a/frontend/src/app/components/key-result-type/key-result-type.component.ts b/frontend/src/app/components/key-result-type/key-result-type.component.ts
@@ -117,15 +117,18 @@ export class KeyResultTypeComponent implements AfterContentInit {
 
     switch (field) {
       case KeyResultMetricField.BASELINE: {
-        return { baseline: roundToTwoDecimals((values.targetValue - values.stretchGoal * 0.7) / 0.3) };
+        return { baseline: roundToTwoDecimals((values.targetValue - values.stretchGoal * 0.7) / 0.3),
+          commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };
       }
 
       case KeyResultMetricField.TARGET_VALUE: {
-        return { targetValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.7 + values.baseline) };
+        return { targetValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.7 + values.baseline),
+          commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };
       }
 
       case KeyResultMetricField.STRETCH_GOAL: {
-        return { stretchGoal: roundToTwoDecimals((values.targetValue - values.baseline) / 0.7 + values.baseline) };
+        return { stretchGoal: roundToTwoDecimals((values.targetValue - values.baseline) / 0.7 + values.baseline),
+          commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };
       }
 
       case KeyResultMetricField.NONE: {

Original file line number	Diff line number	Diff line change
`@@ -117,15 +117,18 @@ export class KeyResultTypeComponent implements AfterContentInit {`
`117`	`117`
`118`	`118`	`switch (field) {`
`119`	`119`	`case KeyResultMetricField.BASELINE: {`
`120`		`- return { baseline: roundToTwoDecimals((values.targetValue - values.stretchGoal * 0.7) / 0.3) };`
	`120`	`+ return { baseline: roundToTwoDecimals((values.targetValue - values.stretchGoal * 0.7) / 0.3),`
	`121`	`+ commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };`
`121`	`122`	`}`
`122`	`123`
`123`	`124`	`case KeyResultMetricField.TARGET_VALUE: {`
`124`		`- return { targetValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.7 + values.baseline) };`
	`125`	`+ return { targetValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.7 + values.baseline),`
	`126`	`+ commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };`
`125`	`127`	`}`
`126`	`128`
`127`	`129`	`case KeyResultMetricField.STRETCH_GOAL: {`
`128`		`- return { stretchGoal: roundToTwoDecimals((values.targetValue - values.baseline) / 0.7 + values.baseline) };`
	`130`	`+ return { stretchGoal: roundToTwoDecimals((values.targetValue - values.baseline) / 0.7 + values.baseline),`
	`131`	`+ commitValue: roundToTwoDecimals((values.stretchGoal - values.baseline) * 0.3 + values.baseline) };`
`129`	`132`	`}`
`130`	`133`
`131`	`134`	`case KeyResultMetricField.NONE: {`