test: Add parameterized tests in Hibernate- and HikariContext #1587

Author: Miguel7373

backend/src/main/java/ch/puzzle/okr/multitenancy/HibernateContext.java

@@ -38,7 +38,7 @@ public static void setHibernateConfig(DbConfig dbConfig) {
     public static void extractAndSetHibernateConfig(ConfigurableEnvironment environment) {
         DbConfig dbConfig = extractHibernateConfig(environment);
         if (!dbConfig.isValid()) {
-            throw new HibernateContextException("Invalid hikari configuration " + dbConfig);
+            throw new HibernateContextException("Invalid hibernate configuration" + dbConfig);
         }
         HibernateContext.setHibernateConfig(dbConfig);
     }

backend/src/test/java/ch/puzzle/okr/multitenancy/HibernateContextTest.java

@@ -7,9 +7,13 @@
 
 import ch.puzzle.okr.exception.HibernateContextException;
 import java.util.Properties;
+import java.util.stream.Stream;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.springframework.core.env.ConfigurableEnvironment;
 
 class HibernateContextTest {
@@ -19,6 +23,35 @@ void setUp() {
         HibernateContext.setHibernateConfig(null);
     }
 
+    private static Stream<Arguments> invalidDbConfig() {
+        return Stream
+                .of( //
+                        Arguments.of(null, "username", "password", "multiTenancy"), //
+                        Arguments.of("", "username", "password", "multiTenancy"), //
+                        Arguments.of("url", null, "password", "multiTenancy"), //
+                        Arguments.of("url", "", "password", "multiTenancy"), //
+                        Arguments.of("url", "username", null, "multiTenancy"), //
+                        Arguments.of("url", "username", "", "multiTenancy"), //
+                        Arguments.of("url", "username", "password", null), //
+                        Arguments.of("url", "username", "password", ""));
+    }
+
+    @ParameterizedTest(name = "extractAndSetHibernateConfig() should throw an exception if dbConfig has null or empty values")
+    @MethodSource("invalidDbConfig")
+    void extractAndSetHibernateConfigShouldThrowExceptionIfDbConfigHasNullOrEmptyValues(String url, String username, String password, String multiTenancy) {
+        // arrange
+        ConfigurableEnvironment environment = mock(ConfigurableEnvironment.class);
+        when(environment.getProperty(HIBERNATE_CONNECTION_URL)).thenReturn(url);
+        when(environment.getProperty(HIBERNATE_CONNECTION_USERNAME)).thenReturn(username);
+        when(environment.getProperty(HIBERNATE_CONNECTION_PASSWORD)).thenReturn(password);
+        when(environment.getProperty(HIBERNATE_MULTITENANCY)).thenReturn(multiTenancy);
+
+        // act + assert
+        HibernateContextException exception = assertThrows(HibernateContextException.class,
+                () -> extractAndSetHibernateConfig(environment));
+        assertTrue(exception.getMessage().startsWith("Invalid hibernate configuration"));
+    }
+
     @DisplayName("extractAndSetHibernateConfig() should extract hibernate properties from environment and set it")
     @Test
     void extractAndSetHibernateConfigShouldExtractHibernatePropertiesFromEnvironmentAndSetIt() {

backend/src/test/java/ch/puzzle/okr/multitenancy/HikariContextTest.java

@@ -9,6 +9,8 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.NullAndEmptySource;
 import org.springframework.core.env.ConfigurableEnvironment;
 
 public class HikariContextTest {
@@ -17,6 +19,19 @@ void setUp() {
         HikariContext.setHikariConfig(null);
     }
 
+    @ParameterizedTest(name = "extractAndSetHikariConfig() should throw an exception if dbConfig has null or empty values")
+    @NullAndEmptySource
+    void extractAndSetHikariConfigShouldThrowExceptionIfDbConfigHasNullOrEmptyValues(String maxPoolSize) {
+        // arrange
+        ConfigurableEnvironment environment = mock(ConfigurableEnvironment.class);
+        when(environment.getProperty(HIKARI_MAXIMUM_POOL_SIZE)).thenReturn(maxPoolSize);
+
+        // act + assert
+        HikariContextException exception = assertThrows(HikariContextException.class,
+                () -> extractAndSetHikariConfig(environment));
+        assertTrue(exception.getMessage().startsWith("Invalid hikari configuration"));
+    }
+
     @DisplayName("extractAndSetHikariConfig() should extract hikari properties from environment and set it")
     @Test
     void extractAndSetHikariConfigShouldExtractHikariPropertiesFromEnvironmentAndSetIt() {