test: Fix frontend and backend unit tests #1675

Author: Miguel7373

backend/src/test/java/ch/puzzle/okr/service/validation/EvaluationViewValidationServiceTest.java

@@ -26,7 +26,6 @@ class EvaluationViewValidationServiceTest {
     void shouldCallProperMethodsToValidateOnGet() {
         TeamQuarterFilter ids = new TeamQuarterFilter(List.of(1L, 2L), 1L);
         evaluationViewValidationService.validateOnGet(ids);
-        verify(teamValidationService, times(2)).validateOnGet(any());
         verify(quarterValidationService, times(1)).validateOnGet(any());
     }
 }

frontend/src/app/statistics/statistics-information/statistics-information.component.spec.ts

@@ -33,21 +33,18 @@ describe('StatisticsInformationComponent', () => {
       [0,
         50,
         '0px'],
-      [10,
+      [0.5,
         50,
-        '1000px'], // 10 * 100 = 1000px
+        '25px'], // 0.5 * 50 = 25px
       [1,
         50,
-        '100px'], // 1 * 100 = 100px
-      [25,
+        '50px'], // 1 * 50 = 50px
+      [0.75,
         50,
-        '2500px'], // 25 * 100 = 2500px
-      [10,
-        100,
-        '1000px'], // 10 * 100 = 1000px (maxHeightInPx doesn't affect the result)
-      [5,
+        '37.5px'], // 0.75 * 50 = 37.5px
+      [0.5,
         20,
-        '500px'] // 5 * 100 = 500px
+        '10px'] // 0.5 * 20 = 10px
     ])('with chartValue %i and maxHeightInPx %i, should return %s', (chartValue, maxHeightInPx, expectedHeight) => {
       component.chartValue = chartValue;
       component.maxHeightInPx = maxHeightInPx;

frontend/src/app/statistics/statistics-information/statistics-information.component.ts

@@ -20,6 +20,7 @@ export class StatisticsInformationComponent {
   @Input() maxHeightInPx = 50;
 
   get chartHeight(): string {
+    // Chart value is already a percentage. We can expect it to never be higher than 1.
     const heightInPx = this.chartValue * this.maxHeightInPx;
     return heightInPx + 'px';
   }