test: check if formcontrol is defined before using its value #1571

Author: nevio18324

frontend/src/app/components/key-result-type/key-result-type.component.spec.ts

@@ -230,9 +230,9 @@ describe('KeyResultTypeComponent', () => {
     KeyResultMetricField.STRETCH_GOAL]])('Should call calculateValueForField with the correct enum', (values: MetricValue, changed: KeyResultMetricField, result: KeyResultMetricField) => {
       const spyInstance = jest.spyOn(component, 'calculateValueForField');
 
-      component.calculateValueAfterChanged(values, changed);
+      component.calculateValueAfterChanged(values, changed, component.keyResultForm);
       expect(spyInstance)
-        .toHaveBeenCalledWith(values, result);
+        .toHaveBeenCalledWith(values, result, component.keyResultForm);
     });
 
     it.each([
@@ -324,7 +324,7 @@ describe('KeyResultTypeComponent', () => {
       KeyResultMetricField.STRETCH_GOAL,
       { stretchGoal: 5 }]
     ])('calculateValueForField should calculate correct', (values: MetricValue, targetField: KeyResultMetricField, result: any) => {
-      expect(component.calculateValueForField(values, targetField))
+      expect(component.calculateValueForField(values, targetField, component.keyResultForm))
         .toEqual(result);
     });
 

frontend/src/app/components/key-result-type/key-result-type.component.ts

@@ -139,7 +139,7 @@ export class KeyResultTypeComponent implements AfterContentInit {
   }
 
   setFormControlValueToZero(formGroupMetric: any, form_control: string) {
-    if (!formGroupMetric.get(form_control).value) {
+    if (formGroupMetric.get(form_control) && !formGroupMetric.get(form_control).value) {
       formGroupMetric.get(form_control)
         .setValue(0, { emitEvent: false });
     }